commit a8c4ce95bd2f4fee4544a57ed86ace3e257c9f24
author Ed Tanous <edtanous@google.com> Wed Mar 24 08:44:51 2021 -0700
committer Ed Tanous <ed@tanous.net> Thu Apr 01 20:55:34 2021 +0000
tree 22f883a8e0f1871c5b8db3fda150a858dc81b47c
parent 0c15c33e0ed36ffedf4905aa671cddbcdcc3d04d

Move requestRoutes to asyncResp

res.end() should be avoided where possible;  This commit changes
requestRoutes to remove the res.end() that's been present there for a
long time.

Tested:
curl -vvvv --insecure --user root:0penBmc https://192.168.7.2/redfish/v1
returns 200

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I798783d320cfb7bc7973a8d2c02c4a25906a3859

include/redfish_v1.hpp

diff --git a/include/redfish_v1.hpp b/include/redfish_v1.hpp
index 7a88cba..76ff457 100644
--- a/include/redfish_v1.hpp
+++ b/include/redfish_v1.hpp
@@ -1,16 +1,23 @@
 #pragma once
 
 #include <app.hpp>
+#include <http_request.hpp>
+#include <http_response.hpp>
+#include <rf_async_resp.hpp>
+
+#include <string>
 
 namespace redfish
 {
+
 inline void requestRoutes(App& app)
 {
     BMCWEB_ROUTE(app, "/redfish/")
         .methods(boost::beast::http::verb::get)(
             [](const crow::Request&, crow::Response& res) {
+                std::shared_ptr<AsyncResp> asyncResp =
+                    std::make_shared<AsyncResp>(res);
                 res.jsonValue = {{"v1", "/redfish/v1/"}};
-                res.end();
             });
 }
 } // namespace redfish

redfish-core/include/node.hpp

diff --git a/redfish-core/include/node.hpp b/redfish-core/include/node.hpp
index f91c22b..43506d5 100644
--- a/redfish-core/include/node.hpp
+++ b/redfish-core/include/node.hpp
@@ -18,8 +18,10 @@
 #include "http_request.hpp"
 #include "http_response.hpp"
 #include "privileges.hpp"
+#include "redfish_v1.hpp"
 
 #include <error_messages.hpp>
+#include <rf_async_resp.hpp>
 
 #include <vector>
 
@@ -27,24 +29,6 @@
 {
 
 /**
- * AsyncResp
- * Gathers data needed for response processing after async calls are done
- */
-class AsyncResp
-{
-  public:
-    AsyncResp(crow::Response& response) : res(response)
-    {}
-
-    ~AsyncResp()
-    {
-        res.end();
-    }
-
-    crow::Response& res;
-};
-
-/**
  * @brief  Abstract class used for implementing Redfish nodes.
  *
  */

redfish-core/include/rf_async_resp.hpp

diff --git a/redfish-core/include/rf_async_resp.hpp b/redfish-core/include/rf_async_resp.hpp
new file mode 100644
index 0000000..27625d5
--- /dev/null
+++ b/redfish-core/include/rf_async_resp.hpp
@@ -0,0 +1,26 @@
+#pragma once
+
+#include "http_response.hpp"
+
+namespace redfish
+{
+
+/**
+ * AsyncResp
+ * Gathers data needed for response processing after async calls are done
+ */
+class AsyncResp
+{
+  public:
+    AsyncResp(crow::Response& response) : res(response)
+    {}
+
+    ~AsyncResp()
+    {
+        res.end();
+    }
+
+    crow::Response& res;
+};
+
+} // namespace redfish
\ No newline at end of file