commit ac106bf6d10841a25088ed14105a73636ba71519
author Ed Tanous <edtanous@google.com> Wed Jun 07 09:24:59 2023 -0700
committer Ed Tanous <ed@tanous.net> Fri Jun 09 16:02:42 2023 +0000
tree f8a3994884fc9ad2ce1df6f8ab50590b707c3ff7
parent 69c3cf09a67041de8084b5f7fa7b0f54725a27fa

Consistently name AsyncResp variables

In about half of our code, AsyncResp objects take the name asyncResp,
and in the other half they take the name aResp.  While the difference
between them is negligeble and arbitrary, having two naming conventions
makes it more difficult to do automated changes over time via grep.

This commit was generated automtatically with the command:
git grep -l 'aResp' | xargs sed -i 's|aResp|asyncResp|g'

Tested: Code compiles.

Change-Id: Id363437b6a78f51e91cbf60aa0a0c2286f36a037
Signed-off-by: Ed Tanous <edtanous@google.com>

redfish-core/lib/sensors.hpp

diff --git a/redfish-core/lib/sensors.hpp b/redfish-core/lib/sensors.hpp
index 3b212c2..49cd087 100644
--- a/redfish-core/lib/sensors.hpp
+++ b/redfish-core/lib/sensors.hpp
@@ -2819,16 +2819,16 @@
     BMCWEB_LOG_DEBUG << "getChassisCallback exit";
 }
 
-inline void
-    handleSensorCollectionGet(App& app, const crow::Request& req,
-                              const std::shared_ptr<bmcweb::AsyncResp>& aResp,
-                              const std::string& chassisId)
+inline void handleSensorCollectionGet(
+    App& app, const crow::Request& req,
+    const std::shared_ptr<bmcweb::AsyncResp>& asyncResp,
+    const std::string& chassisId)
 {
     query_param::QueryCapabilities capabilities = {
         .canDelegateExpandLevel = 1,
     };
     query_param::Query delegatedQuery;
-    if (!redfish::setUpRedfishRouteWithDelegation(app, req, aResp,
+    if (!redfish::setUpRedfishRouteWithDelegation(app, req, asyncResp,
                                                   delegatedQuery, capabilities))
     {
         return;
@@ -2837,11 +2837,11 @@
     if (delegatedQuery.expandType != query_param::ExpandType::None)
     {
         // we perform efficient expand.
-        auto asyncResp = std::make_shared<SensorsAsyncResp>(
-            aResp, chassisId, sensors::dbus::sensorPaths,
+        auto sensorsAsyncResp = std::make_shared<SensorsAsyncResp>(
+            asyncResp, chassisId, sensors::dbus::sensorPaths,
             sensors::node::sensors,
             /*efficientExpand=*/true);
-        getChassisData(asyncResp);
+        getChassisData(sensorsAsyncResp);
 
         BMCWEB_LOG_DEBUG
             << "SensorCollection doGet exit via efficient expand handler";
@@ -2850,9 +2850,9 @@
 
     // We get all sensors as hyperlinkes in the chassis (this
     // implies we reply on the default query parameters handler)
-    getChassis(aResp, chassisId, sensors::node::sensors, dbus::sensorPaths,
-               std::bind_front(sensors::getChassisCallback, aResp, chassisId,
-                               sensors::node::sensors));
+    getChassis(asyncResp, chassisId, sensors::node::sensors, dbus::sensorPaths,
+               std::bind_front(sensors::getChassisCallback, asyncResp,
+                               chassisId, sensors::node::sensors));
 }
 
 inline void