commit ac25adb8d491342fc5fd4e189c58b79be6f5835a
author Ed Tanous <ed@tanous.net> Sat Apr 13 11:57:35 2024 -0700
committer Ed Tanous <ed@tanous.net> Mon Apr 15 15:25:52 2024 +0000
tree 5b12d55641c58e3cb48c7c9846d93a3c1ad4c381
parent 87c449664e5375abb040af6fad63ef965c311bec

Fix Privileges warnings

After splitting up the compile units, warnings start showing up on the
console about privileges.  This is due to them being a static global,
and not shared between the compile units.

Move the array to a constexpr structure so that all compile units see
the same init.

Change-Id: I6e035342a5b229a0601c02092ca3ce665b14bbdb
Signed-off-by: Ed Tanous <ed@tanous.net>

redfish-core/include/privileges.hpp

diff --git a/redfish-core/include/privileges.hpp b/redfish-core/include/privileges.hpp
index 8b42208..1225cdf 100644
--- a/redfish-core/include/privileges.hpp
+++ b/redfish-core/include/privileges.hpp
@@ -45,7 +45,7 @@
 };
 
 /** @brief A fixed array of compile time privileges  */
-constexpr std::array<const char*, 5> basePrivileges{
+constexpr std::array<std::string_view, 5> basePrivileges{
     "Login", "ConfigureManager", "ConfigureComponents", "ConfigureSelf",
     "ConfigureUsers"};
 
@@ -60,7 +60,7 @@
  * "hostconsole" user group. This privilege is required to access the host
  * console.
  */
-static const std::array<std::string, maxPrivilegeCount> privilegeNames{
+constexpr std::array<std::string_view, maxPrivilegeCount> privilegeNames{
     "Login",         "ConfigureManager", "ConfigureComponents",
     "ConfigureSelf", "ConfigureUsers",   "OpenBMCHostConsole"};
 
@@ -102,7 +102,7 @@
         {
             if (!setSinglePrivilege(privilege))
             {
-                BMCWEB_LOG_CRITICAL("Unable to set privilege {}in constructor",
+                BMCWEB_LOG_CRITICAL("Unable to set privilege {} in constructor",
                                     privilege);
             }
         }