commit ad7fa9027b890255b802941558405c04d1cfb23b
author Patrick Williams <patrick@stwcx.xyz> Wed May 10 19:57:29 2023 -0500
committer Patrick Williams <patrick@stwcx.xyz> Wed May 10 22:24:35 2023 -0500
tree d27faa05f6b47575d5cb356e4a66d1a2353635db
parent 0e31e95217e477620cba456393368183dea55d75

pam-authenticate: fix clang-tidy warning

```
../include/pam_authenticate.hpp:11:75: error: 'msg' is an unsafe pointer used for buffer access [-Werror,-Wunsafe-buffer-usage]
inline int pamFunctionConversation(int numMsg, const struct pam_message** msg,
```

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic0e6d63b01eea78cac54407246363177cb208f8b

include/pam_authenticate.hpp

diff --git a/include/pam_authenticate.hpp b/include/pam_authenticate.hpp
index 5802078..7af28ad 100644
--- a/include/pam_authenticate.hpp
+++ b/include/pam_authenticate.hpp
@@ -6,12 +6,13 @@
 
 #include <cstring>
 #include <memory>
+#include <span>
 
 // function used to get user input
 inline int pamFunctionConversation(int numMsg, const struct pam_message** msg,
                                    struct pam_response** resp, void* appdataPtr)
 {
-    if (appdataPtr == nullptr)
+    if ((appdataPtr == nullptr) || (msg == nullptr) || (resp == nullptr))
     {
         return PAM_CONV_ERR;
     }
@@ -21,11 +22,14 @@
         return PAM_CONV_ERR;
     }
 
-    for (int i = 0; i < numMsg; ++i)
+    auto msgCount = static_cast<size_t>(numMsg);
+    auto messages = std::span(msg, msgCount);
+    auto responses = std::span(resp, msgCount);
+
+    for (size_t i = 0; i < msgCount; ++i)
     {
         /* Ignore all PAM messages except prompting for hidden input */
-        // NOLINTNEXTLINE(cppcoreguidelines-pro-bounds-pointer-arithmetic)
-        if (msg[i]->msg_style != PAM_PROMPT_ECHO_OFF)
+        if (messages[i]->msg_style != PAM_PROMPT_ECHO_OFF)
         {
             continue;
         }
@@ -69,8 +73,7 @@
         // NOLINTNEXTLINE(cppcoreguidelines-pro-type-reinterpret-cast)
         *resp = reinterpret_cast<pam_response*>(ptr);
 
-        // NOLINTNEXTLINE(cppcoreguidelines-pro-bounds-pointer-arithmetic)
-        resp[i]->resp = pass;
+        responses[i]->resp = pass;
 
         return PAM_SUCCESS;
     }