tree 2d4e3720b31c0792ad493481946263090d8a6ddc
parent 2b3da45876aac57a36d3093379a992d699e7e396
author Adriana Kobylak <anoo@us.ibm.com> 1613057590 -0600
committer Adriana Kobylak <anoo@us.ibm.com> 1613061114 -0600

log_services: Improve error handling for DBus Log Entry

Improve the error handling of the DBus Log Entry class:
1. Return internal error only if message, id, or severity are
   not initialized.
2. Handle Not Found error (404).
3. Escape the Entry ID used for the DBus call.

Tested:
A call to entries/foo returns not found:
$ curl -k -H "X-Auth-Token: $token" https://${bmc}/redfish/v1/Systems/system/LogServices/EventLog/Entries/foo
{
  "error": {
    "@Message.ExtendedInfo": [
      {
        "@odata.type": "#Message.v1_1_1.Message",
        "Message": "The requested resource of type EventLogEntry named foo was not found.",
        "MessageArgs": [
          "EventLogEntry",
          "foo"
        ],
        "MessageId": "Base.1.8.1.ResourceNotFound",
        "MessageSeverity": "Critical",
        "Resolution": "Provide a valid resource identifier and resubmit the request."
      }
    ],
    "code": "Base.1.8.1.ResourceNotFound",
    "message": "The requested resource of type EventLogEntry named foo was not found."
  }

Change-Id: Icac06b34c9d4bc570973da369eef42fd785b4bf7
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>