tree ff39c461464538d64fa3969fb7a1890aac6d23d3
parent f610caaeaebc3b6aeaef3cd293ae6e43339af315
author Claire Weinan <cweinan@google.com> 1657937839 -0700
committer Ed Tanous <ed@tanous.net> 1659563133 +0000

LogService: Refactor dump entry parsing

Refactored common code for parsing dump entry information from D-Bus
response objects (shared by getDumpEntryCollection() and
getDumpEntryById()) into a new function parseDumpEntryFromDbusObject().
The parsing is similar to what is done by parseCrashdumpParameters().

This refactoring is being done in anticipation of adding additional
D-Bus property parsing for dump entries (without this refactoring,
code duplication will increase).

No noticeable client impact.

Tested:

Get dump entries individually and as a collection.
  Example commands:
  curl -k -H "X-Auth-Token: $token" -X GET http://${bmc}/redfish/v1/Managers/bmc/LogServices/FaultLog/Entries

  curl -k -H "X-Auth-Token: $token" -X GET
  http://${bmc}/redfish/v1/Managers/bmc/LogServices/FaultLog/Entries/1

  curl -k -H "X-Auth-Token: $token" -X GET http://${bmc}/redfish/v1/Managers/bmc/LogServices/Dump/Entries

  curl -k -H "X-Auth-Token: $token" -X GET http://${bmc}/redfish/v1/Managers/bmc/LogServices/Dump/Entries/1

Redfish Service Validator succeeded on the following URI trees:
/redfish/v1/Managers/bmc/LogServices/FaultLog
/redfish/v1/Managers/bmc/LogServices/Dump
/redfish/v1/Systems/system/LogServices/Dump

Signed-off-by: Claire Weinan <cweinan@google.com>
Change-Id: If67fb0c1f35175ae0e2968f8d7a52c13e66b1dc7