Remove messages::operationFailed from processor
A file write error being returned from dbus is by definition, an
internal error that the user can do nothing about, so it should be
returning internal error (ie 500) to the user, rather than
OperationFailed. OperationFailed refers to aggregation proxy use cases,
so its use here, while an understandable mistake, because dbus is
arguably a "proxy", is incorrect, and should be fixed.
Tested: Code compiles, no good way to test error cases. Inspection
only.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I01aae6bcf377d019ff6e868309f87959281a2156
diff --git a/redfish-core/lib/processor.hpp b/redfish-core/lib/processor.hpp
index e0346de..1b7fa9a 100644
--- a/redfish-core/lib/processor.hpp
+++ b/redfish-core/lib/processor.hpp
@@ -977,13 +977,6 @@
// in a different system state.
messages::resourceInStandby(resp->res);
}
- else if (strcmp(dbusError->name,
- "xyz.openbmc_project.Common.Device.Error.WriteFailure") ==
- 0)
- {
- // Service tried to change the config, but it failed.
- messages::operationFailed(resp->res);
- }
else
{
messages::internalError(resp->res);