fix more push vs emplace calls
It seems like clang-tidy doesn't catch every place that an emplace could
be used instead of a push. Use a few grep/sed pairs to find and fix up
some common patterns.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I93eaec26b8e3be240599e92b66cf54947073dc4c
diff --git a/redfish-core/lib/update_service.hpp b/redfish-core/lib/update_service.hpp
index 59b2b3b..b6c0487 100644
--- a/redfish-core/lib/update_service.hpp
+++ b/redfish-core/lib/update_service.hpp
@@ -908,7 +908,7 @@
member["@odata.id"] = crow::utility::urlFromPieces(
"redfish", "v1", "UpdateService", "FirmwareInventory",
swId);
- members.push_back(std::move(member));
+ members.emplace_back(std::move(member));
asyncResp->res.jsonValue["Members@odata.count"] =
members.size();
}
@@ -925,7 +925,7 @@
nlohmann::json& relatedItem = aResp->res.jsonValue["RelatedItem"];
nlohmann::json::object_t item;
item["@odata.id"] = "/redfish/v1/Managers/bmc";
- relatedItem.push_back(std::move(item));
+ relatedItem.emplace_back(std::move(item));
aResp->res.jsonValue["RelatedItem@odata.count"] = relatedItem.size();
}
else if (purpose == sw_util::biosPurpose)
@@ -933,7 +933,7 @@
nlohmann::json& relatedItem = aResp->res.jsonValue["RelatedItem"];
nlohmann::json::object_t item;
item["@odata.id"] = "/redfish/v1/Systems/system/Bios";
- relatedItem.push_back(std::move(item));
+ relatedItem.emplace_back(std::move(item));
aResp->res.jsonValue["RelatedItem@odata.count"] = relatedItem.size();
}
else