tree 20c37adf5a627cbd09e05ad9875480626c708b3f
parent 7be4c8adf0e831c5a5465afebcb4e7c364963da7
author Ed Tanous <edtanous@google.com> 1656636706 -0700
committer Ed Tanous <ed@tanous.net> 1660676290 +0000

task payload, initialize jsonValue in constructor

We should do this because it means that variables are only initialized
once.  In the simplest case:

struct MyClass{
std::string myString

    MyClass(){
       myString = "foo";

    }

}

in the language, myString is constructed twice, once with empty string,
then a second time with "foo".  If you do the construction in the
initializer list for the class the construction only happens once.

Now, the above case is contrived, the optimizer can see through it and
likely optimizes this case because std::string is relatively simple, but
for more complex structures, it's possible this generates less and
bettercompiled code, and this is worth having the check for, and making
our existing code correct.

Tested: cppcheck passing.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Ie5c7f293598408d437e7bf7b3fc93b0819e25f9f