commit b41187fac9d82be2ea26bd8695f2beba135e80f1
author Ed Tanous <ed.tanous@intel.com> Thu Oct 24 16:30:02 2019 -0700
committer James Feist <james.feist@linux.intel.com> Thu Jul 16 09:30:30 2020 -0700
tree 1a0dd10ee2c3d2e470e9ccbfe7cb7171753673e1
parent 3909dc82a003893812f598434d6c4558107afa28

Deprecate the "" operator, and isEqP

While a cool example of how to do string matching in constexpr space,
the set of verbs available to HTTP has been fixed for a very long time.

This was ported over to beast a while back, but we kept the API for....
mediocre reasons of backward compatibility.  Remove that, and delete the
now unused code.

Tested: Built and loaded on a Witherspoon. Validator passes.

Signed-off-by: Ed Tanous <ed.tanous@intel.com>
Change-Id: Iaf048e196f9b6e71983189877203bf80390df286
Signed-off-by: James Feist <james.feist@linux.intel.com>
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

src/crow_test.cpp

diff --git a/src/crow_test.cpp b/src/crow_test.cpp
index f53e519..4e0bd40 100644
--- a/src/crow_test.cpp
+++ b/src/crow_test.cpp
@@ -324,22 +324,25 @@
 {
     SimpleApp app;
 
-    BMCWEB_ROUTE(app, "/").methods("POST"_method,
-                                   "GET"_method)([](const Request& req) {
-        if (req.method() == "GET"_method)
-            return "2";
-        else
-            return "1";
-    });
+    BMCWEB_ROUTE(app, "/").methods(boost::beast::http::verb::post,
+                                   boost::beast::http::verb::get)(
+        [](const Request& req) {
+            if (req.method() == boost::beast::http::verb::get)
+                return "2";
+            else
+                return "1";
+        });
 
     BMCWEB_ROUTE(app, "/get_only")
-        .methods("GET"_method)([](const Request& /*req*/) { return "get"; });
+        .methods(boost::beast::http::verb::get)(
+            [](const Request& /*req*/) { return "get"; });
     BMCWEB_ROUTE(app, "/post_only")
-        .methods("POST"_method)([](const Request& /*req*/) { return "post"; });
+        .methods(boost::beast::http::verb::post)(
+            [](const Request& /*req*/) { return "post"; });
 
     // cannot have multiple handlers for the same url
     // BMCWEB_ROUTE(app, "/")
-    //.methods("GET"_method)
+    //.methods(boost::beast::http::verb::get)
     //([]{ return "2"; });
 
     {
@@ -358,7 +361,7 @@
         Response res;
 
         req.url = "/";
-        r.method("POST"_method);
+        r.method(boost::beast::http::verb::post);
         app.handle(req, res);
 
         ASSERT_EQUAL("1", res.body());
@@ -381,7 +384,7 @@
         Response res;
 
         req.url = "/get_only";
-        r.method("POST"_method);
+        r.method(boost::beast::http::verb::post);
         app.handle(req, res);
 
         ASSERT_NOTEQUAL("get", res.body());
@@ -421,10 +424,12 @@
 {
     static char buf[2048];
     SimpleApp app1, app2;
-    BMCWEB_ROUTE(app1, "/").methods("GET"_method,
-                                    "POST"_method)([] { return "A"; });
-    BMCWEB_ROUTE(app2, "/").methods("GET"_method,
-                                    "POST"_method)([] { return "B"; });
+    BMCWEB_ROUTE(app1, "/").methods(boost::beast::http::verb::get,
+                                    boost::beast::http::verb::post)(
+        [] { return "A"; });
+    BMCWEB_ROUTE(app2, "/").methods(boost::beast::http::verb::get,
+                                    boost::beast::http::verb::post)(
+        [] { return "B"; });
 
     Server<SimpleApp> server1(&app1, LOCALHOST_ADDRESS, 45451);
     Server<SimpleApp> server2(&app2, LOCALHOST_ADDRESS, 45452);