Lots of performance improvements
(In the voice of the kid from sixth sense) I see string copies...
Apparently there are a lot of places we make unnecessary copies. This
fixes all of them.
Not sure how to split this up into smaller patches, or if it even needs
split up. It seems pretty easy to review to me, because basically every
diff is identical.
Change-Id: I22b4ae4f96f7e4082d2bc701098a04f7bed95369
Signed-off-by: Ed Tanous <ed@tanous.net>
Signed-off-by: Wludzik, Jozef <jozef.wludzik@intel.com>
diff --git a/redfish-core/lib/update_service.hpp b/redfish-core/lib/update_service.hpp
index e3e6bbb..7e6a0b8 100644
--- a/redfish-core/lib/update_service.hpp
+++ b/redfish-core/lib/update_service.hpp
@@ -60,7 +60,7 @@
// Note that asyncResp can be either a valid pointer or nullptr. If nullptr
// then no asyncResp updates will occur
-static void softwareInterfaceAdded(std::shared_ptr<AsyncResp> asyncResp,
+static void softwareInterfaceAdded(const std::shared_ptr<AsyncResp>& asyncResp,
sdbusplus::message::message& m,
const crow::Request& req)
{
@@ -256,10 +256,9 @@
// Note that asyncResp can be either a valid pointer or nullptr. If nullptr
// then no asyncResp updates will occur
-static void monitorForSoftwareAvailable(std::shared_ptr<AsyncResp> asyncResp,
- const crow::Request& req,
- const std::string& url,
- int timeoutTimeSeconds = 10)
+static void monitorForSoftwareAvailable(
+ const std::shared_ptr<AsyncResp>& asyncResp, const crow::Request& req,
+ const std::string& url, int timeoutTimeSeconds = 10)
{
// Only allow one FW update at a time
if (fwUpdateInProgress != false)
@@ -775,7 +774,7 @@
private:
/* Fill related item links (i.e. bmc, bios) in for inventory */
- static void getRelatedItems(std::shared_ptr<AsyncResp> aResp,
+ static void getRelatedItems(const std::shared_ptr<AsyncResp>& aResp,
const std::string& purpose)
{
if (purpose == fw_util::bmcPurpose)