commit b5b62cc15edd2f4f2053a629cbcf6340b15e307e
author Willy Tu <wltu@google.com> Thu Jun 08 08:48:19 2023 -0700
committer Ed Tanous <ed@tanous.net> Thu Jun 08 18:05:01 2023 +0000
tree af636538d3394bb4c93a6a4f0ac35fec20355f37
parent c51a58ee9231e48bb25ede75307591758f911395

hex_units: Fix Werror=conversion

Convert all types to uint8_t to not hit the conversion warning.

Change-Id: Ia535ca0a2f4045cbde06a2f8f8eaad9570a0f4a5
Signed-off-by: Willy Tu <wltu@google.com>
Signed-off-by: Ed Tanous <edtanous@google.com>

redfish-core/include/utils/hex_utils.hpp

diff --git a/redfish-core/include/utils/hex_utils.hpp b/redfish-core/include/utils/hex_utils.hpp
index f3728ea..07ef4c8 100644
--- a/redfish-core/include/utils/hex_utils.hpp
+++ b/redfish-core/include/utils/hex_utils.hpp
@@ -43,11 +43,11 @@
     }
     else if (ch >= 'A' && ch <= 'F')
     {
-        rc = static_cast<uint8_t>(ch) - 'A' + 10;
+        rc = static_cast<uint8_t>(ch - 'A') + 10U;
     }
     else if (ch >= 'a' && ch <= 'f')
     {
-        rc = static_cast<uint8_t>(ch) - 'a' + 10;
+        rc = static_cast<uint8_t>(ch - 'a') + 10U;
     }
 
     return rc;

test/redfish-core/include/utils/hex_utils_test.cpp

diff --git a/test/redfish-core/include/utils/hex_utils_test.cpp b/test/redfish-core/include/utils/hex_utils_test.cpp
index d96e4d4..c80158a 100644
--- a/test/redfish-core/include/utils/hex_utils_test.cpp
+++ b/test/redfish-core/include/utils/hex_utils_test.cpp
@@ -54,11 +54,11 @@
         }
         else if (c >= 'A' && c <= 'F')
         {
-            expected = static_cast<uint8_t>(c) - 'A' + 10;
+            expected = static_cast<uint8_t>(c - 'A') + 10U;
         }
         else if (c >= 'a' && c <= 'f')
         {
-            expected = static_cast<uint8_t>(c) - 'a' + 10;
+            expected = static_cast<uint8_t>(c - 'a') + 10U;
         }
 
         EXPECT_EQ(hexCharToNibble(c), expected);