commit b74e4405a20d1212b5e5ac73854b86007c716d51
author Ed Tanous <ed@tanous.net> Wed Sep 09 20:26:26 2020 -0700
committer Ed Tanous <ed@tanous.net> Fri Sep 11 17:18:51 2020 +0000
tree f2b3771b35f817b1955eceee9e4d97001e2406bc
parent 9cf21522554fb4db984ea3291bb512c9737b0a0d

Remove tick timer

External tick timers were never something we used, so they're
effectively dead code, even if they do still execute.

Remove them.

Tested:
Loaded bmcweb on a system, and pulled down webui-vue.

Signed-off-by: Ed Tanous <ed@tanous.net>
Change-Id: I65bbc24d59cfa45adeb013055a2eab2eeb26ad3d

http/http_server.h

diff --git a/http/http_server.h b/http/http_server.h
index b5fd4da..422b3a7 100644
--- a/http/http_server.h
+++ b/http/http_server.h
@@ -37,8 +37,8 @@
                std::make_shared<boost::asio::io_context>()) :
         ioService(std::move(io)),
         acceptor(std::move(acceptorIn)),
-        signals(*ioService, SIGINT, SIGTERM, SIGHUP), tickTimer(*ioService),
-        timer(*ioService), handler(handlerIn), adaptorCtx(adaptor_ctx)
+        signals(*ioService, SIGINT, SIGTERM, SIGHUP), timer(*ioService),
+        handler(handlerIn), adaptorCtx(adaptor_ctx)
     {}
 
     Server(Handler* handlerIn, const std::string& bindaddr, uint16_t port,
@@ -62,26 +62,6 @@
                adaptor_ctx, io)
     {}
 
-    void setTickFunction(std::chrono::milliseconds d, std::function<void()> f)
-    {
-        tickInterval = d;
-        tickFunction = f;
-    }
-
-    void onTick()
-    {
-        tickFunction();
-        tickTimer.expires_after(
-            std::chrono::milliseconds(tickInterval.count()));
-        tickTimer.async_wait([this](const boost::system::error_code& ec) {
-            if (ec)
-            {
-                return;
-            }
-            onTick();
-        });
-    }
-
     void updateDateStr()
     {
         time_t lastTimeT = time(nullptr);
@@ -125,19 +105,6 @@
         };
         timer.async_wait(timerHandler);
 
-        if (tickFunction && tickInterval.count() > 0)
-        {
-            tickTimer.expires_after(
-                std::chrono::milliseconds(tickInterval.count()));
-            tickTimer.async_wait([this](const boost::system::error_code& ec) {
-                if (ec)
-                {
-                    return;
-                }
-                onTick();
-            });
-        }
-
         BMCWEB_LOG_INFO << serverName << " server is running, local endpoint "
                         << acceptor->local_endpoint();
         startAsyncWaitForSignal();
@@ -258,7 +225,6 @@
     std::function<std::string()> getCachedDateStr;
     std::unique_ptr<tcp::acceptor> acceptor;
     boost::asio::signal_set signals;
-    boost::asio::steady_timer tickTimer;
     boost::asio::steady_timer timer;
 
     std::string dateStr;
@@ -266,8 +232,6 @@
     Handler* handler;
     std::string serverName = "bmcweb";
 
-    std::chrono::milliseconds tickInterval{};
-    std::function<void()> tickFunction;
     std::function<void(const boost::system::error_code& ec)> timerHandler;
 
 #ifdef BMCWEB_ENABLE_SSL