commit b84e729dfcc428c2696b86b09e736ecdd10db2ff
author Ed Tanous <edtanous@google.com> Thu May 11 14:17:33 2023 -0700
committer Ed Tanous <ed@tanous.net> Fri May 12 18:22:12 2023 +0000
tree 2da44a3421ffd06f2774523bd994d17702a629bc
parent c16e292cfbacdff61ec09224e4cc7d92933a07dd

Revert "http_connection: Allow empty json objects"

This reverts commit 02e01b5108d46720a0b438c0d79952464320d954.

This commit is being reverted because it causes login failures on
Firefox browsers.  This commit originally was added with the idea that
it did not fix anything on upstream, but made some peoples forks better.

It appears to have broken some upstream things, so the right thing to do
is to revert it until those breakages can be understood.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I04de84fca1a8de657f6941653f2a3e595ee725d5

http/http_connection.hpp

diff --git a/http/http_connection.hpp b/http/http_connection.hpp
index c8ae1fd..d4428df 100644
--- a/http/http_connection.hpp
+++ b/http/http_connection.hpp
@@ -342,7 +342,7 @@
 
         res.setHashAndHandleNotModified();
 
-        if (res.body().empty() && !res.jsonValue.is_null())
+        if (res.body().empty() && !res.jsonValue.empty())
         {
             using http_helpers::ContentType;
             std::array<ContentType, 3> allowed{