Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / bmcweb / b9d679d1ce64141342e8a845533ce6af9901aae8
commitb9d679d1ce64141342e8a845533ce6af9901aae8[log] [tgz]
authorMichael Shen <gpgpgp@google.com>Mon Feb 13 02:29:04 2023 +0000
committerEd Tanous <ed@tanous.net>Tue Feb 28 03:00:40 2023 +0000
tree3ef3e69e3d65ec08d8e106156485690822276a7a
parent6c068982d54d20476fd04ae7ef893b153015762e [diff]
processor: Change `Step` default value to USHRT_MAX

Change `Step` default value to USHRT_MAX due to
https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/60717

For a new processor, it's possible that the stepping is really `0`. In
this case, the `Step` will still be ignored which is not expected.

https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/60717
changes the `Step` default value to `maxint`. Thus the `Step` can
correctly display 0 on redfish.

Tested:
1. Redfish service validator passing.
2. bmcweb works fine without errors.
3. Step was hidden when its value is 65535 (max uint16_t).
4. Step also displayed even the value is `0`.
```
root@machine:~# curl localhost/redfish/v1/Systems/system/Processors/cpu0
    ...
    "Step": "0x0000"
    ...
```

Change-Id: I1857fc597ef2ab13256dc60e534c23d452e5d695
Signed-off-by: Michael Shen <gpgpgp@google.com>
1 file changed
tree: 3ef3e69e3d65ec08d8e106156485690822276a7a
  1. .github/
  2. config/
  3. http/
  4. include/
  5. redfish-core/
  6. scripts/
  7. src/
  8. static/
  9. subprojects/
  10. test/
  11. .clang-format
  12. .clang-tidy
  13. .dockerignore
  14. .gitignore
  15. .markdownlint.yaml
  16. .openbmc-enforce-gitlint
  17. .prettierignore
  18. .shellcheck
  19. CLIENTS.md
  20. COMMON_ERRORS.md
  21. DBUS_USAGE.md
  22. DEVELOPING.md
  23. HEADERS.md
  24. LICENSE
  25. meson.build
  26. meson_options.txt
  27. OEM_SCHEMAS.md
  28. OWNERS
  29. README.md
  30. Redfish.md
  31. run-ci
  32. setup.cfg
  33. TESTING.md
README.md

OpenBMC webserver

This component attempts to be a "do everything" embedded webserver for OpenBMC.

Features

The webserver implements a few distinct interfaces:

  • DBus event websocket. Allows registering on changes to specific dbus paths, properties, and will send an event from the websocket if those filters match.
  • OpenBMC DBus REST api. Allows direct, low interference, high fidelity access to dbus and the objects it represents.
  • Serial: A serial websocket for interacting with the host serial console through websockets.
  • Redfish: A protocol compliant, DBus to Redfish translator.
  • KVM: A websocket based implementation of the RFB (VNC) frame buffer protocol intended to mate to webui-vue to provide a complete KVM implementation.

Protocols

bmcweb at a protocol level supports http and https. TLS is supported through OpenSSL.

AuthX

Authentication

Bmcweb supports multiple authentication protocols:

  • Basic authentication per RFC7617
  • Cookie based authentication for authenticating against webui-vue
  • Mutual TLS authentication based on OpenSSL
  • Session authentication through webui-vue
  • XToken based authentication conformant to Redfish DSP0266

Each of these types of authentication is able to be enabled or disabled both via runtime policy changes (through the relevant Redfish APIs) or via configure time options. All authentication mechanisms supporting username/password are routed to libpam, to allow for customization in authentication implementations.

Authorization

All authorization in bmcweb is determined at routing time, and per route, and conform to the Redfish PrivilegeRegistry.

*Note: Non-Redfish functions are mapped to the closest equivalent Redfish privilege level.

Configuration

bmcweb is configured per the meson build files. Available options are documented in meson_options.txt

Compile bmcweb with default options

meson builddir
ninja -C builddir

If any of the dependencies are not found on the host system during configuration, meson will automatically download them via its wrap dependencies mentioned in bmcweb/subprojects.

Debug logging

bmcweb by default is compiled with runtime logging disabled, as a performance consideration. To enable it in a standalone build, add the

-Dlogging='enabled'

option to your configure flags. If building within Yocto, add the following to your local.conf.

EXTRA_OEMESON:pn-bmcweb:append = "-Dbmcweb-logging='enabled'"

Use of persistent data

bmcweb relies on some on-system data for storage of persistent data that is internal to the process. Details on the exact data stored and when it is read/written can seen from the persistent_data namespace.

TLS certificate generation

When SSL support is enabled and a usable certificate is not found, bmcweb will generate a self-signed a certificate before launching the server. Please see the bmcweb source code for details on the parameters this certificate is built with.