commit b9d679d1ce64141342e8a845533ce6af9901aae8
author Michael Shen <gpgpgp@google.com> Mon Feb 13 02:29:04 2023 +0000
committer Ed Tanous <ed@tanous.net> Tue Feb 28 03:00:40 2023 +0000
tree 3ef3e69e3d65ec08d8e106156485690822276a7a
parent 6c068982d54d20476fd04ae7ef893b153015762e

processor: Change `Step` default value to USHRT_MAX

Change `Step` default value to USHRT_MAX due to
https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/60717

For a new processor, it's possible that the stepping is really `0`. In
this case, the `Step` will still be ignored which is not expected.

https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/60717
changes the `Step` default value to `maxint`. Thus the `Step` can
correctly display 0 on redfish.

Tested:
1. Redfish service validator passing.
2. bmcweb works fine without errors.
3. Step was hidden when its value is 65535 (max uint16_t).
4. Step also displayed even the value is `0`.
```
root@machine:~# curl localhost/redfish/v1/Systems/system/Processors/cpu0
    ...
    "Step": "0x0000"
    ...
```

Change-Id: I1857fc597ef2ab13256dc60e534c23d452e5d695
Signed-off-by: Michael Shen <gpgpgp@google.com>

redfish-core/lib/processor.hpp

diff --git a/redfish-core/lib/processor.hpp b/redfish-core/lib/processor.hpp
index 51290b8..cd9850e 100644
--- a/redfish-core/lib/processor.hpp
+++ b/redfish-core/lib/processor.hpp
@@ -34,6 +34,7 @@
 #include <sdbusplus/utility/dedup_variant.hpp>
 
 #include <array>
+#include <limits>
 #include <string_view>
 
 namespace redfish
@@ -205,7 +206,7 @@
                     messages::internalError(aResp->res);
                     return;
                 }
-                if (*value != 0)
+                if (*value != std::numeric_limits<uint16_t>::max())
                 {
                     aResp->res.jsonValue["ProcessorId"]["Step"] =
                         "0x" + intToHexString(*value, 4);