commit c7d3422c108c6a88bbeffcea3edbb3f59e3992e3
author Wludzik, Jozef <jozef.wludzik@intel.com> Mon Oct 19 12:59:41 2020 +0200
committer Jozef Wludzik <jozef.wludzik@intel.com> Thu Oct 22 06:23:24 2020 +0000
tree bd6bf11ba93dec9114ac962ebab35416fa430fb3
parent 3fad0d59b94d951a752530d01db5451773f7d374

Avoid using deleted Connection in Response

Connection is destroyed when completeRequestHandler is nulled. It
causes that memory is freed. When Response::end() is called and
connection is not alive, completeRequest() method removes last
shared_ptr reference by setting nullptr on completeRequestHandler
member of Response. In this moment code is executed on destroyed
object and can cause stack overflow.
Fixed it by moving a call to completeRequest method to Asio
executor in completeRequestHandler.

Tested:
 - Ran stress test that send a lot of GET and POST requests
   without a bmcweb service crash

Change-Id: Idcf6a06dac32e9eac08285b9b53a5e8afe36c955
Signed-off-by: Wludzik, Jozef <jozef.wludzik@intel.com>

http/http_connection.h

diff --git a/http/http_connection.h b/http/http_connection.h
index ca3314b..8aaabcd 100644
--- a/http/http_connection.h
+++ b/http/http_connection.h
@@ -340,7 +340,8 @@
             {
                 needToCallAfterHandlers = true;
                 res.completeRequestHandler = [self(shared_from_this())] {
-                    self->completeRequest();
+                    boost::asio::post(self->adaptor.get_executor(),
+                                      [self] { self->completeRequest(); });
                 };
                 if (req->isUpgrade() &&
                     boost::iequals(