commit ca45aa3c416e55027b8d17078bac6493e81d564f
author Ed Tanous <edtanous@google.com> Fri Jan 07 09:28:45 2022 -0800
committer Ed Tanous <ed@tanous.net> Wed Jan 12 19:00:37 2022 +0000
tree 6b23f35cfba77f66557e78230b85684cef0f5c04
parent 46ff87bade273c75f71f940c5770d30e7a29595b

Enable checks for pointer arithmetic

Quite a few places we've disobeyed this rule, so simply ignore them for
now to avoid new issues popping up.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I3e518a8e8742279afb3ad1a9dad54006ed109fb1

http/http_connection.hpp

diff --git a/http/http_connection.hpp b/http/http_connection.hpp
index 840f2b6..ad6855f 100644
--- a/http/http_connection.hpp
+++ b/http/http_connection.hpp
@@ -182,11 +182,13 @@
 
             for (int i = 0; i < usage->length; i++)
             {
-                if (KU_DIGITAL_SIGNATURE & usage->data[i])
+                // NOLINTNEXTLINE(cppcoreguidelines-pro-bounds-pointer-arithmetic)
+                unsigned char usageChar = usage->data[i];
+                if (KU_DIGITAL_SIGNATURE & usageChar)
                 {
                     isKeyUsageDigitalSignature = true;
                 }
-                if (KU_KEY_AGREEMENT & usage->data[i])
+                if (KU_KEY_AGREEMENT & usageChar)
                 {
                     isKeyUsageKeyAgreement = true;
                 }