commit ca723762cdc83a2ad0bc75807d287abce219636d
author Ed Tanous <edtanous@google.com> Tue Jun 28 19:40:39 2022 -0700
committer Ed Tanous <ed@tanous.net> Fri Jul 01 23:02:11 2022 +0000
tree 665610769092381e74f676d816a91fc61f9d5674
parent e3009e4645d3a4ecaf2e65f75c6b997a5ed5dbfb

Fix unused branches in http_client

cppcheck correctly finds that these branches will always be hit, so the
branch is unneeded.  Let's start by getting the code cleaned up.

Tested: CI only, cpp check.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I7b89337a81e676915243d5bc9d26c24a89c74aef

http/http_client.hpp

diff --git a/http/http_client.hpp b/http/http_client.hpp
index 14e2cf2..ca350c7 100644
--- a/http/http_client.hpp
+++ b/http/http_client.hpp
@@ -371,10 +371,8 @@
         BMCWEB_LOG_DEBUG << host << ":" << std::to_string(port)
                          << ", id: " << std::to_string(connId)
                          << " closed gracefully";
-        if ((state != ConnState::suspended) && (state != ConnState::terminated))
-        {
-            state = ConnState::closed;
-        }
+
+        state = ConnState::closed;
     }
 
     void doCloseAndRetry()
@@ -395,12 +393,10 @@
         BMCWEB_LOG_DEBUG << host << ":" << std::to_string(port)
                          << ", id: " << std::to_string(connId)
                          << " closed gracefully";
-        if ((state != ConnState::suspended) && (state != ConnState::terminated))
-        {
-            // Now let's try to resend the data
-            state = ConnState::retry;
-            this->doResolve();
-        }
+
+        // Now let's try to resend the data
+        state = ConnState::retry;
+        doResolve();
     }
 
   public: