Enable unused variable warnings and resolve
This commit enables the "unused variables" warning in clang. Throughout
this, it did point out several issues that would've been functional
bugs, so I think it was worthwhile. It also cleaned up several unused
variable from old constructs that no longer exist.
Tested:
Built with clang. Code no longer emits warnings.
Downloaded bmcweb to system and pulled up the webui, observed webui
loads and logs in properly.
Change-Id: I51505f4222cc147d6f2b87b14d7e2ac4a74cafa8
Signed-off-by: Ed Tanous <ed@tanous.net>
diff --git a/redfish-core/lib/led.hpp b/redfish-core/lib/led.hpp
index a2a5bc9..f9e0c47 100644
--- a/redfish-core/lib/led.hpp
+++ b/redfish-core/lib/led.hpp
@@ -120,8 +120,7 @@
}
crow::connections::systemBus->async_method_call(
- [aResp, ledOn, ledBlinkng](const boost::system::error_code ec,
- const std::variant<bool> asserted) mutable {
+ [aResp, ledOn, ledBlinkng](const boost::system::error_code ec) mutable {
if (ec)
{
// Some systems may not have enclosure_identify_blink object so
@@ -133,8 +132,7 @@
}
}
crow::connections::systemBus->async_method_call(
- [aResp](const boost::system::error_code ec2,
- const std::variant<bool> asserted2) {
+ [aResp](const boost::system::error_code ec2) {
if (ec2)
{
BMCWEB_LOG_DEBUG << "DBUS response error " << ec2;