Remove unused variables in connection class
Both of these variables are leftover from when middlewares existed in
this codebase, and are essentially unused. The only use is to buffer
cleanupTempSession, which in practice, doesn't require the variable, and
can be run in all cases.
Because this code is "cleaning up" the basic auth session that got
created when the request started, in theory, if the request failed, it's
possible we didn't create a session, but that can happen through the
golden path too, if we access an unprotected resource, or access with
non basic auth, so there's no reason to hide this behind the "did the
middlewares fail" check. This got stuck under the check because of the
way the middlewares used to be ordered, to keep "identical" code paths.
Tested:
curl -vvvv --insecure --auth root:0penBmc"https://192.168.7.2:443/redfish/v1/Systems"
Succeeded with and without the --auth flag. This tests basic auth,
which is the only thing that could've been potentially changed as part
of this commit.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I8d2500fd2abaab3b23abed51a9a9f55e8d171b76
diff --git a/http/http_connection.hpp b/http/http_connection.hpp
index a4723f1..6d1c13c 100644
--- a/http/http_connection.hpp
+++ b/http/http_connection.hpp
@@ -347,8 +347,6 @@
BMCWEB_LOG_ERROR << p.what();
}
- needToCallAfterHandlers = false;
-
if (!isInvalidRequest)
{
res.setCompleteRequestHandler(nullptr);
@@ -359,7 +357,6 @@
if (!res.completed)
{
- needToCallAfterHandlers = true;
res.setCompleteRequestHandler([self(shared_from_this())] {
boost::asio::post(self->adaptor.get_executor(),
[self] { self->completeRequest(); });
@@ -434,10 +431,7 @@
addSecurityHeaders(*req, res);
- if (needToCallAfterHandlers)
- {
- crow::authorization::cleanupTempSession(*req);
- }
+ crow::authorization::cleanupTempSession(*req);
if (!isAlive())
{
@@ -801,9 +795,6 @@
std::optional<size_t> timerCancelKey;
- bool needToCallAfterHandlers{};
- bool needToStartReadAfterComplete{};
-
std::function<std::string()>& getCachedDateStr;
detail::TimerQueue& timerQueue;