Implement bugprone-branch-clone compliance
As part of getting the clang-tidy bugprone tests running, these
conditionals were found to have duplicate entries, or be somewhat
nonsensical.
Tested: clang-tidy now passes with the branch-compliance check set.
Change-Id: Ibec106f3bbd866fc471a1fc56bd8cdd5d44024e0
diff --git a/redfish-core/lib/log_services.hpp b/redfish-core/lib/log_services.hpp
index 0e93f5c..777f37e 100644
--- a/redfish-core/lib/log_services.hpp
+++ b/redfish-core/lib/log_services.hpp
@@ -107,31 +107,16 @@
inline std::string translateSeverityDbusToRedfish(const std::string& s)
{
- if (s == "xyz.openbmc_project.Logging.Entry.Level.Alert")
+ if ((s == "xyz.openbmc_project.Logging.Entry.Level.Alert") ||
+ (s == "xyz.openbmc_project.Logging.Entry.Level.Critical") ||
+ (s == "xyz.openbmc_project.Logging.Entry.Level.Emergency") ||
+ (s == "xyz.openbmc_project.Logging.Entry.Level.Error"))
{
return "Critical";
}
- else if (s == "xyz.openbmc_project.Logging.Entry.Level.Critical")
- {
- return "Critical";
- }
- else if (s == "xyz.openbmc_project.Logging.Entry.Level.Debug")
- {
- return "OK";
- }
- else if (s == "xyz.openbmc_project.Logging.Entry.Level.Emergency")
- {
- return "Critical";
- }
- else if (s == "xyz.openbmc_project.Logging.Entry.Level.Error")
- {
- return "Critical";
- }
- else if (s == "xyz.openbmc_project.Logging.Entry.Level.Informational")
- {
- return "OK";
- }
- else if (s == "xyz.openbmc_project.Logging.Entry.Level.Notice")
+ else if ((s == "xyz.openbmc_project.Logging.Entry.Level.Debug") ||
+ (s == "xyz.openbmc_project.Logging.Entry.Level.Informational") ||
+ (s == "xyz.openbmc_project.Logging.Entry.Level.Notice"))
{
return "OK";
}