tree 2bbb8dbb164443c963c5556bfb18d80e20153cb8
parent 49cc263fdcfc9b279c399c0b03bfd7e9167e06c2
author Ed Tanous <ed@tanous.net> 1710637481 -0700
committer Ed Tanous <ed@tanous.net> 1711567079 +0000

Check optionals in tidy

clang-tidy-18 makes this feature stable enough for us to use in general.
Enable the check, and fix the couple of regressions that have snuck in
since we last ran the check.

Tidy seems to not be able to understand that ASSERT will not continue,
so if we ASSERT a std::optional, it's not a bug.  Add explicit checks to
keep tidy happy.

Tested: clang-tidy passes.

Change-Id: I0986453851da5471056a7b47b8ad57a9801df259
Signed-off-by: Ed Tanous <ed@tanous.net>