commit d5736ef260c5534fb2fe2ee895d62e91bc9319c3
author Ed Tanous <edtanous@google.com> Thu Jul 06 10:37:23 2023 -0700
committer Ed Tanous <ed@tanous.net> Mon Jul 10 21:03:04 2023 +0000
tree e52b9651fd4f994a604d35ff62e2d09550a014ef
parent d9fcfcc174eb0e195105f3ba2e95456db29a4132

Enable bugprone clang tidy checks

We pass basically all of these with flying colors now.  Previously there
were clang-tidy bugs around bugprone-exception-escape, but those seem to
be resolved in clang-tidy-16, so we can turn that check back on.

The only thing we had was an instance of
bugprone-assignment-in-if-condition, that was trivially fixed.

Tested: Clang-tidy passes.

Change-Id: Ib2e63e951ee8e4e46f0d1b40bf41f8dca59c9a08
Signed-off-by: Ed Tanous <edtanous@google.com>

redfish-core/lib/trigger.hpp

diff --git a/redfish-core/lib/trigger.hpp b/redfish-core/lib/trigger.hpp
index 33e3bde..cd1b60f 100644
--- a/redfish-core/lib/trigger.hpp
+++ b/redfish-core/lib/trigger.hpp
@@ -606,7 +606,8 @@
 
     if (metricType)
     {
-        if (!(ctx.metricType = getMetricType(*metricType)))
+        ctx.metricType = getMetricType(*metricType);
+        if (!ctx.metricType)
         {
             messages::propertyValueIncorrect(res, "MetricType", *metricType);
             return false;
@@ -615,8 +616,8 @@
 
     if (discreteTriggerCondition)
     {
-        if (!(ctx.discreteCondition =
-                  getDiscreteCondition(*discreteTriggerCondition)))
+        ctx.discreteCondition = getDiscreteCondition(*discreteTriggerCondition);
+        if (!ctx.discreteCondition)
         {
             messages::propertyValueIncorrect(res, "DiscreteTriggerCondition",
                                              *discreteTriggerCondition);