Fix includes
Clang-tidy misc-include-cleaner appears to now be enforcing
significantly more headers than previously. That is overall a good
thing, but forces us to fix some issues. This commit is largely just
taking the clang-recommended fixes and checking them in. Subsequent
patches will fix the more unique issues.
Note, that a number of new ignores are added into the .clang-tidy file.
These can be cleaned up over time as they're understood. The majority
are places where boost includes a impl/x.hpp and x.hpp, but expects you
to use the later. include-cleaner opts for the impl, but it isn't clear
why.
Change-Id: Id3fdd7ee6df6c33b2fd35626898523048dd51bfb
Signed-off-by: Ed Tanous <etanous@nvidia.com>
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
diff --git a/http/http_client.hpp b/http/http_client.hpp
index 58078c4..6e5613b 100644
--- a/http/http_client.hpp
+++ b/http/http_client.hpp
@@ -3,38 +3,60 @@
// SPDX-FileCopyrightText: Copyright 2020 Intel Corporation
#pragma once
+#include "bmcweb_config.h"
+
#include "async_resolve.hpp"
+#include "boost_formatters.hpp"
#include "http_body.hpp"
#include "http_response.hpp"
#include "logging.hpp"
#include "ssl_key_handler.hpp"
+#include <openssl/err.h>
+#include <openssl/ssl.h>
+#include <openssl/tls1.h>
+
#include <boost/asio/connect.hpp>
+#include <boost/asio/error.hpp>
#include <boost/asio/io_context.hpp>
#include <boost/asio/ip/address.hpp>
-#include <boost/asio/ip/basic_endpoint.hpp>
#include <boost/asio/ip/tcp.hpp>
#include <boost/asio/ssl/context.hpp>
#include <boost/asio/ssl/error.hpp>
#include <boost/asio/ssl/stream.hpp>
+#include <boost/asio/ssl/stream_base.hpp>
#include <boost/asio/steady_timer.hpp>
+#include <boost/beast/core/error.hpp>
#include <boost/beast/core/flat_static_buffer.hpp>
+#include <boost/beast/http/field.hpp>
+#include <boost/beast/http/fields.hpp>
#include <boost/beast/http/message.hpp>
-#include <boost/beast/http/message_generator.hpp>
#include <boost/beast/http/parser.hpp>
#include <boost/beast/http/read.hpp>
+#include <boost/beast/http/status.hpp>
+#include <boost/beast/http/verb.hpp>
#include <boost/beast/http/write.hpp>
#include <boost/container/devector.hpp>
+#include <boost/optional/optional.hpp>
+#include <boost/system/errc.hpp>
#include <boost/system/error_code.hpp>
-#include <boost/url/format.hpp>
+#include <boost/url/host_type.hpp>
#include <boost/url/url.hpp>
#include <boost/url/url_view_base.hpp>
+#include <chrono>
+#include <cstdint>
#include <cstdlib>
+#include <format>
#include <functional>
#include <memory>
-#include <queue>
+#include <optional>
#include <string>
+#include <string_view>
+#include <type_traits>
+#include <unordered_map>
+#include <utility>
+#include <vector>
namespace crow
{