Fix includes
Clang-tidy misc-include-cleaner appears to now be enforcing
significantly more headers than previously. That is overall a good
thing, but forces us to fix some issues. This commit is largely just
taking the clang-recommended fixes and checking them in. Subsequent
patches will fix the more unique issues.
Note, that a number of new ignores are added into the .clang-tidy file.
These can be cleaned up over time as they're understood. The majority
are places where boost includes a impl/x.hpp and x.hpp, but expects you
to use the later. include-cleaner opts for the impl, but it isn't clear
why.
Change-Id: Id3fdd7ee6df6c33b2fd35626898523048dd51bfb
Signed-off-by: Ed Tanous <etanous@nvidia.com>
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
diff --git a/include/file_test_utilities.hpp b/include/file_test_utilities.hpp
index 73d1359..1d55509 100644
--- a/include/file_test_utilities.hpp
+++ b/include/file_test_utilities.hpp
@@ -1,6 +1,9 @@
// SPDX-License-Identifier: Apache-2.0
// SPDX-FileCopyrightText: Copyright OpenBMC Authors
#pragma once
+#include <unistd.h>
+
+#include <cstdlib>
#include <filesystem>
#include <string>
#include <string_view>
@@ -20,6 +23,7 @@
{
stringPath = path.string();
+ // NOLINTNEXTLINE(misc-include-cleaner)
int fd = mkstemp(stringPath.data());
EXPECT_GT(fd, 0);
EXPECT_EQ(write(fd, sampleData.data(), sampleData.size()),