Fix includes
Clang-tidy misc-include-cleaner appears to now be enforcing
significantly more headers than previously. That is overall a good
thing, but forces us to fix some issues. This commit is largely just
taking the clang-recommended fixes and checking them in. Subsequent
patches will fix the more unique issues.
Note, that a number of new ignores are added into the .clang-tidy file.
These can be cleaned up over time as they're understood. The majority
are places where boost includes a impl/x.hpp and x.hpp, but expects you
to use the later. include-cleaner opts for the impl, but it isn't clear
why.
Change-Id: Id3fdd7ee6df6c33b2fd35626898523048dd51bfb
Signed-off-by: Ed Tanous <etanous@nvidia.com>
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
diff --git a/redfish-core/lib/account_service.hpp b/redfish-core/lib/account_service.hpp
index bc4706b..c021ee2 100644
--- a/redfish-core/lib/account_service.hpp
+++ b/redfish-core/lib/account_service.hpp
@@ -3,13 +3,22 @@
// SPDX-FileCopyrightText: Copyright 2018 Intel Corporation
#pragma once
+#include "bmcweb_config.h"
+
#include "app.hpp"
+#include "async_resp.hpp"
#include "boost_formatters.hpp"
#include "certificate_service.hpp"
+#include "dbus_singleton.hpp"
#include "dbus_utility.hpp"
#include "error_messages.hpp"
#include "generated/enums/account_service.hpp"
+#include "http_request.hpp"
+#include "http_response.hpp"
+#include "logging.hpp"
+#include "pam_authenticate.hpp"
#include "persistent_data.hpp"
+#include "privileges.hpp"
#include "query.hpp"
#include "registries/privilege_registry.hpp"
#include "sessions.hpp"
@@ -17,18 +26,32 @@
#include "utils/dbus_utils.hpp"
#include "utils/json_utils.hpp"
+#include <security/_pam_types.h>
+#include <systemd/sd-bus.h>
+
+#include <boost/beast/http/field.hpp>
+#include <boost/beast/http/status.hpp>
+#include <boost/beast/http/verb.hpp>
#include <boost/url/format.hpp>
#include <boost/url/url.hpp>
-#include <sdbusplus/asio/property.hpp>
+#include <nlohmann/json.hpp>
+#include <sdbusplus/message.hpp>
#include <sdbusplus/unpack_properties.hpp>
+#include <algorithm>
#include <array>
+#include <cstddef>
+#include <cstdint>
+#include <cstring>
+#include <format>
+#include <functional>
#include <memory>
#include <optional>
#include <ranges>
#include <string>
#include <string_view>
#include <utility>
+#include <variant>
#include <vector>
namespace redfish
diff --git a/redfish-core/lib/aggregation_service.hpp b/redfish-core/lib/aggregation_service.hpp
index 4b89286..a15a9bf 100644
--- a/redfish-core/lib/aggregation_service.hpp
+++ b/redfish-core/lib/aggregation_service.hpp
@@ -3,18 +3,25 @@
#pragma once
#include "app.hpp"
+#include "async_resp.hpp"
#include "error_messages.hpp"
#include "http_request.hpp"
#include "http_response.hpp"
+#include "logging.hpp"
#include "query.hpp"
#include "redfish_aggregator.hpp"
#include "registries/privilege_registry.hpp"
+#include <boost/beast/http/field.hpp>
+#include <boost/beast/http/verb.hpp>
#include <boost/url/format.hpp>
+#include <boost/url/url.hpp>
#include <nlohmann/json.hpp>
#include <functional>
#include <memory>
+#include <unordered_map>
+#include <utility>
namespace redfish
{
diff --git a/redfish-core/lib/bios.hpp b/redfish-core/lib/bios.hpp
index 4ad58f3..f4026fd 100644
--- a/redfish-core/lib/bios.hpp
+++ b/redfish-core/lib/bios.hpp
@@ -2,12 +2,24 @@
// SPDX-FileCopyrightText: Copyright OpenBMC Authors
#pragma once
+#include "bmcweb_config.h"
+
#include "app.hpp"
+#include "async_resp.hpp"
+#include "dbus_singleton.hpp"
+#include "error_messages.hpp"
+#include "http_request.hpp"
+#include "logging.hpp"
#include "query.hpp"
#include "registries/privilege_registry.hpp"
#include "utils/sw_utils.hpp"
-#include <boost/url/format.hpp>
+#include <boost/beast/http/verb.hpp>
+
+#include <format>
+#include <functional>
+#include <memory>
+#include <string>
namespace redfish
{
diff --git a/redfish-core/lib/cable.hpp b/redfish-core/lib/cable.hpp
index b92848b..13ec64a 100644
--- a/redfish-core/lib/cable.hpp
+++ b/redfish-core/lib/cable.hpp
@@ -2,20 +2,33 @@
// SPDX-FileCopyrightText: Copyright OpenBMC Authors
#pragma once
+#include "app.hpp"
+#include "async_resp.hpp"
+#include "dbus_singleton.hpp"
#include "dbus_utility.hpp"
+#include "error_messages.hpp"
#include "generated/enums/resource.hpp"
+#include "http_request.hpp"
+#include "http_response.hpp"
+#include "logging.hpp"
#include "query.hpp"
#include "registries/privilege_registry.hpp"
#include "utils/collection.hpp"
#include "utils/dbus_utils.hpp"
-#include "utils/json_utils.hpp"
+#include <asm-generic/errno.h>
+
+#include <boost/beast/http/verb.hpp>
#include <boost/system/error_code.hpp>
#include <boost/url/format.hpp>
-#include <sdbusplus/asio/property.hpp>
+#include <boost/url/url.hpp>
+#include <sdbusplus/message/native_types.hpp>
#include <sdbusplus/unpack_properties.hpp>
#include <array>
+#include <cmath>
+#include <memory>
+#include <string>
#include <string_view>
namespace redfish
diff --git a/redfish-core/lib/certificate_service.hpp b/redfish-core/lib/certificate_service.hpp
index 1b77147..cb391bc 100644
--- a/redfish-core/lib/certificate_service.hpp
+++ b/redfish-core/lib/certificate_service.hpp
@@ -2,26 +2,61 @@
// SPDX-FileCopyrightText: Copyright OpenBMC Authors
#pragma once
+#include "bmcweb_config.h"
+
#include "app.hpp"
#include "async_resp.hpp"
+#include "dbus_singleton.hpp"
#include "dbus_utility.hpp"
+#include "error_messages.hpp"
#include "http/parsing.hpp"
+#include "http_request.hpp"
#include "http_response.hpp"
+#include "logging.hpp"
+#include "privileges.hpp"
#include "query.hpp"
#include "registries/privilege_registry.hpp"
+#include "utility.hpp"
#include "utils/dbus_utils.hpp"
#include "utils/json_utils.hpp"
#include "utils/time_utils.hpp"
-#include <boost/system/linux_error.hpp>
+// NOLINTNEXTLINE(modernize-deprecated-headers)
+#include <stdlib.h>
+#include <systemd/sd-bus.h>
+
+#include <boost/asio/error.hpp>
+#include <boost/asio/steady_timer.hpp>
+#include <boost/beast/http/field.hpp>
+#include <boost/beast/http/status.hpp>
+#include <boost/beast/http/verb.hpp>
+#include <boost/system/result.hpp>
#include <boost/url/format.hpp>
-#include <sdbusplus/asio/property.hpp>
+#include <boost/url/parse.hpp>
+#include <boost/url/url.hpp>
+#include <nlohmann/json.hpp>
#include <sdbusplus/bus/match.hpp>
+#include <sdbusplus/message.hpp>
+#include <sdbusplus/message/native_types.hpp>
#include <sdbusplus/unpack_properties.hpp>
#include <array>
+#include <chrono>
+#include <cstddef>
+#include <cstdint>
+#include <cstdlib>
+#include <filesystem>
+#include <format>
+#include <fstream>
+#include <functional>
+#include <iterator>
#include <memory>
+#include <optional>
+#include <string>
#include <string_view>
+#include <system_error>
+#include <utility>
+#include <vector>
namespace redfish
{
diff --git a/redfish-core/lib/chassis.hpp b/redfish-core/lib/chassis.hpp
index d2004fb..53f3e40 100644
--- a/redfish-core/lib/chassis.hpp
+++ b/redfish-core/lib/chassis.hpp
@@ -3,29 +3,48 @@
// SPDX-FileCopyrightText: Copyright 2018 Intel Corporation
#pragma once
+#include "bmcweb_config.h"
+
#include "app.hpp"
+#include "async_resp.hpp"
+#include "dbus_singleton.hpp"
#include "dbus_utility.hpp"
+#include "error_messages.hpp"
#include "generated/enums/action_info.hpp"
#include "generated/enums/chassis.hpp"
#include "generated/enums/resource.hpp"
+#include "http_request.hpp"
#include "led.hpp"
+#include "logging.hpp"
#include "query.hpp"
-#include "redfish_util.hpp"
#include "registries/privilege_registry.hpp"
#include "utils/collection.hpp"
#include "utils/dbus_utils.hpp"
#include "utils/json_utils.hpp"
+#include <asm-generic/errno.h>
+
+#include <boost/beast/http/field.hpp>
+#include <boost/beast/http/verb.hpp>
#include <boost/system/error_code.hpp>
#include <boost/url/format.hpp>
+#include <boost/url/url.hpp>
+#include <nlohmann/json.hpp>
#include <sdbusplus/asio/property.hpp>
-#include <sdbusplus/message.hpp>
+#include <sdbusplus/message/native_types.hpp>
#include <sdbusplus/unpack_properties.hpp>
+#include <algorithm>
#include <array>
+#include <format>
+#include <functional>
#include <memory>
+#include <optional>
#include <ranges>
+#include <string>
#include <string_view>
+#include <utility>
+#include <vector>
namespace redfish
{
diff --git a/redfish-core/lib/environment_metrics.hpp b/redfish-core/lib/environment_metrics.hpp
index 7743486..9d92fd4 100644
--- a/redfish-core/lib/environment_metrics.hpp
+++ b/redfish-core/lib/environment_metrics.hpp
@@ -3,15 +3,22 @@
#pragma once
#include "app.hpp"
+#include "async_resp.hpp"
+#include "error_messages.hpp"
+#include "http_request.hpp"
#include "query.hpp"
#include "registries/privilege_registry.hpp"
#include "utils/chassis_utils.hpp"
+#include <boost/beast/http/field.hpp>
+#include <boost/beast/http/verb.hpp>
#include <boost/url/format.hpp>
+#include <functional>
#include <memory>
#include <optional>
#include <string>
+#include <utility>
namespace redfish
{
diff --git a/redfish-core/lib/ethernet.hpp b/redfish-core/lib/ethernet.hpp
index cda4db3..8d43820 100644
--- a/redfish-core/lib/ethernet.hpp
+++ b/redfish-core/lib/ethernet.hpp
@@ -3,28 +3,52 @@
// SPDX-FileCopyrightText: Copyright 2018 Intel Corporation
#pragma once
+#include "bmcweb_config.h"
+
#include "app.hpp"
+#include "async_resp.hpp"
#include "dbus_singleton.hpp"
#include "dbus_utility.hpp"
#include "error_messages.hpp"
#include "generated/enums/ethernet_interface.hpp"
#include "generated/enums/resource.hpp"
+#include "http_request.hpp"
+#include "http_response.hpp"
#include "human_sort.hpp"
+#include "logging.hpp"
#include "query.hpp"
#include "registries/privilege_registry.hpp"
+#include "utility.hpp"
+#include "utils/dbus_utils.hpp"
#include "utils/ip_utils.hpp"
#include "utils/json_utils.hpp"
-#include <boost/system/error_code.hpp>
-#include <boost/url/format.hpp>
+#include <systemd/sd-bus.h>
-#include <array>
+#include <boost/beast/http/verb.hpp>
+#include <boost/system/error_code.hpp>
+#include <boost/system/result.hpp>
+#include <boost/url/format.hpp>
+#include <boost/url/parse.hpp>
+#include <boost/url/url.hpp>
+#include <boost/url/url_view.hpp>
+#include <sdbusplus/message.hpp>
+#include <sdbusplus/message/native_types.hpp>
+#include <sdbusplus/unpack_properties.hpp>
+
+#include <algorithm>
+#include <cctype>
#include <cstddef>
+#include <cstdint>
+#include <format>
+#include <functional>
#include <memory>
#include <optional>
#include <ranges>
#include <regex>
+#include <string>
#include <string_view>
+#include <utility>
#include <variant>
#include <vector>
diff --git a/redfish-core/lib/event_service.hpp b/redfish-core/lib/event_service.hpp
index fd26864..42eb638 100644
--- a/redfish-core/lib/event_service.hpp
+++ b/redfish-core/lib/event_service.hpp
@@ -3,29 +3,47 @@
// SPDX-FileCopyrightText: Copyright 2020 Intel Corporation
#pragma once
#include "app.hpp"
+#include "async_resp.hpp"
+#include "dbus_singleton.hpp"
+#include "dbus_utility.hpp"
+#include "error_messages.hpp"
#include "event_service_manager.hpp"
-#include "generated/enums/event_service.hpp"
+#include "event_service_store.hpp"
+#include "generated/enums/event_destination.hpp"
#include "http/utility.hpp"
+#include "http_request.hpp"
#include "logging.hpp"
#include "query.hpp"
#include "registries.hpp"
#include "registries/privilege_registry.hpp"
#include "registries_selector.hpp"
#include "snmp_trap_event_clients.hpp"
+#include "subscription.hpp"
#include "utils/json_utils.hpp"
-#include <boost/beast/http/fields.hpp>
-#include <boost/system/error_code.hpp>
-#include <boost/url/parse.hpp>
-#include <sdbusplus/unpack_properties.hpp>
-#include <utils/dbus_utils.hpp>
+#include <asm-generic/errno.h>
-#include <charconv>
+#include <boost/beast/http/fields.hpp>
+#include <boost/beast/http/status.hpp>
+#include <boost/beast/http/verb.hpp>
+#include <boost/system/error_code.hpp>
+#include <boost/system/result.hpp>
+#include <boost/url/format.hpp>
+#include <boost/url/parse.hpp>
+#include <boost/url/url.hpp>
+#include <sdbusplus/message/native_types.hpp>
+
+#include <algorithm>
+#include <array>
+#include <cerrno>
+#include <cstddef>
+#include <cstdint>
#include <memory>
#include <optional>
#include <ranges>
#include <span>
#include <string>
+#include <utility>
#include <vector>
namespace redfish
diff --git a/redfish-core/lib/eventservice_sse.hpp b/redfish-core/lib/eventservice_sse.hpp
index f61d553..86bf1d1 100644
--- a/redfish-core/lib/eventservice_sse.hpp
+++ b/redfish-core/lib/eventservice_sse.hpp
@@ -2,14 +2,21 @@
// SPDX-FileCopyrightText: Copyright OpenBMC Authors
#pragma once
-#include "filter_expr_executor.hpp"
-#include "privileges.hpp"
+#include "filter_expr_parser_ast.hpp"
+#include "filter_expr_printer.hpp"
+#include "http_request.hpp"
+#include "logging.hpp"
#include "registries/privilege_registry.hpp"
+#include "server_sent_event.hpp"
+#include "subscription.hpp"
#include <app.hpp>
+#include <boost/url/params_base.hpp>
#include <event_service_manager.hpp>
+#include <format>
#include <memory>
+#include <optional>
#include <string>
namespace redfish
diff --git a/redfish-core/lib/fabric_adapters.hpp b/redfish-core/lib/fabric_adapters.hpp
index 0e0c5f0..acd6d8f 100644
--- a/redfish-core/lib/fabric_adapters.hpp
+++ b/redfish-core/lib/fabric_adapters.hpp
@@ -2,26 +2,34 @@
// SPDX-FileCopyrightText: Copyright OpenBMC Authors
#pragma once
+#include "bmcweb_config.h"
+
#include "app.hpp"
+#include "async_resp.hpp"
#include "dbus_utility.hpp"
+#include "error_messages.hpp"
#include "generated/enums/resource.hpp"
+#include "http_request.hpp"
+#include "logging.hpp"
#include "query.hpp"
#include "registries/privilege_registry.hpp"
#include "utils/collection.hpp"
#include "utils/dbus_utils.hpp"
-#include "utils/json_utils.hpp"
+#include <asm-generic/errno.h>
+
+#include <boost/beast/http/field.hpp>
+#include <boost/beast/http/verb.hpp>
#include <boost/system/error_code.hpp>
#include <boost/url/format.hpp>
-#include <sdbusplus/asio/property.hpp>
#include <sdbusplus/unpack_properties.hpp>
#include <array>
#include <functional>
#include <memory>
-#include <optional>
#include <string>
#include <string_view>
+#include <utility>
namespace redfish
{
diff --git a/redfish-core/lib/fan.hpp b/redfish-core/lib/fan.hpp
index 1c5095c..d426709 100644
--- a/redfish-core/lib/fan.hpp
+++ b/redfish-core/lib/fan.hpp
@@ -3,23 +3,32 @@
#pragma once
#include "app.hpp"
+#include "async_resp.hpp"
#include "dbus_utility.hpp"
#include "error_messages.hpp"
#include "generated/enums/resource.hpp"
+#include "http_request.hpp"
+#include "logging.hpp"
#include "query.hpp"
#include "registries/privilege_registry.hpp"
#include "utils/chassis_utils.hpp"
+#include <asm-generic/errno.h>
+
+#include <boost/beast/http/field.hpp>
+#include <boost/beast/http/verb.hpp>
#include <boost/system/error_code.hpp>
#include <boost/url/format.hpp>
-#include <sdbusplus/asio/property.hpp>
-#include <sdbusplus/message/types.hpp>
+#include <nlohmann/json.hpp>
+#include <sdbusplus/unpack_properties.hpp>
+#include <array>
#include <functional>
#include <memory>
#include <optional>
#include <string>
#include <string_view>
+#include <utility>
namespace redfish
{
diff --git a/redfish-core/lib/hypervisor_system.hpp b/redfish-core/lib/hypervisor_system.hpp
index 210bfa7..b5e2f2d 100644
--- a/redfish-core/lib/hypervisor_system.hpp
+++ b/redfish-core/lib/hypervisor_system.hpp
@@ -2,26 +2,40 @@
// SPDX-FileCopyrightText: Copyright OpenBMC Authors
#pragma once
+#include "bmcweb_config.h"
+
#include "app.hpp"
-#include "dbus_singleton.hpp"
+#include "async_resp.hpp"
#include "dbus_utility.hpp"
#include "error_messages.hpp"
#include "ethernet.hpp"
#include "generated/enums/action_info.hpp"
#include "generated/enums/computer_system.hpp"
#include "generated/enums/resource.hpp"
+#include "http_request.hpp"
+#include "logging.hpp"
#include "query.hpp"
#include "registries/privilege_registry.hpp"
+#include "utils/dbus_utils.hpp"
#include "utils/ip_utils.hpp"
#include "utils/json_utils.hpp"
+#include <boost/beast/http/status.hpp>
+#include <boost/beast/http/verb.hpp>
#include <boost/url/format.hpp>
-#include <sdbusplus/asio/property.hpp>
+#include <sdbusplus/message/native_types.hpp>
#include <array>
+#include <cstddef>
+#include <cstdint>
+#include <functional>
+#include <memory>
#include <optional>
+#include <string>
#include <string_view>
#include <utility>
+#include <variant>
+#include <vector>
namespace redfish
{
diff --git a/redfish-core/lib/led.hpp b/redfish-core/lib/led.hpp
index 2f10584..ed4c188 100644
--- a/redfish-core/lib/led.hpp
+++ b/redfish-core/lib/led.hpp
@@ -3,13 +3,18 @@
// SPDX-FileCopyrightText: Copyright 2019 Intel Corporation
#pragma once
-#include "app.hpp"
#include "async_resp.hpp"
+#include "dbus_singleton.hpp"
#include "dbus_utility.hpp"
+#include "error_messages.hpp"
#include "generated/enums/chassis.hpp"
-#include "redfish_util.hpp"
+#include "logging.hpp"
+#include "utils/dbus_utils.hpp"
#include <sdbusplus/asio/property.hpp>
+#include <sdbusplus/message/native_types.hpp>
+
+#include <memory>
namespace redfish
{
diff --git a/redfish-core/lib/log_services.hpp b/redfish-core/lib/log_services.hpp
index 665e058..c47e45f 100644
--- a/redfish-core/lib/log_services.hpp
+++ b/redfish-core/lib/log_services.hpp
@@ -3,47 +3,72 @@
// SPDX-FileCopyrightText: Copyright 2018 Intel Corporation
#pragma once
+#include "bmcweb_config.h"
+
#include "app.hpp"
+#include "async_resp.hpp"
+#include "dbus_singleton.hpp"
#include "dbus_utility.hpp"
#include "error_messages.hpp"
#include "generated/enums/log_entry.hpp"
#include "generated/enums/log_service.hpp"
+#include "http_body.hpp"
+#include "http_request.hpp"
+#include "http_response.hpp"
#include "http_utility.hpp"
#include "human_sort.hpp"
+#include "logging.hpp"
#include "query.hpp"
#include "registries.hpp"
-#include "registries/base_message_registry.hpp"
-#include "registries/openbmc_message_registry.hpp"
#include "registries/privilege_registry.hpp"
+#include "str_utility.hpp"
#include "task.hpp"
#include "task_messages.hpp"
#include "utils/dbus_event_log_entry.hpp"
#include "utils/dbus_utils.hpp"
#include "utils/json_utils.hpp"
+#include "utils/query_param.hpp"
#include "utils/time_utils.hpp"
-#include <systemd/sd-id128.h>
+#include <asm-generic/errno.h>
+#include <systemd/sd-bus.h>
#include <tinyxml2.h>
#include <unistd.h>
+#include <boost/beast/http/field.hpp>
+#include <boost/beast/http/status.hpp>
#include <boost/beast/http/verb.hpp>
-#include <boost/container/flat_map.hpp>
#include <boost/system/linux_error.hpp>
#include <boost/url/format.hpp>
-#include <sdbusplus/asio/property.hpp>
+#include <boost/url/url.hpp>
+#include <sdbusplus/message.hpp>
+#include <sdbusplus/message/native_types.hpp>
#include <sdbusplus/unpack_properties.hpp>
+#include <algorithm>
#include <array>
-#include <charconv>
+#include <chrono>
#include <cstddef>
+#include <cstdint>
+#include <cstdio>
+#include <ctime>
#include <filesystem>
+#include <format>
+#include <fstream>
+#include <functional>
+#include <iomanip>
#include <iterator>
+#include <memory>
#include <optional>
#include <ranges>
#include <span>
+#include <sstream>
#include <string>
#include <string_view>
+#include <system_error>
+#include <utility>
#include <variant>
+#include <vector>
namespace redfish
{
@@ -65,8 +90,6 @@
DUMP_CREATE_INPROGRESS
};
-namespace fs = std::filesystem;
-
inline std::string translateSeverityDbusToRedfish(const std::string& s)
{
if ((s == "xyz.openbmc_project.Logging.Entry.Level.Alert") ||
diff --git a/redfish-core/lib/manager_diagnostic_data.hpp b/redfish-core/lib/manager_diagnostic_data.hpp
index 174e876..fb3a040 100644
--- a/redfish-core/lib/manager_diagnostic_data.hpp
+++ b/redfish-core/lib/manager_diagnostic_data.hpp
@@ -2,24 +2,31 @@
// SPDX-FileCopyrightText: Copyright OpenBMC Authors
#pragma once
+#include "bmcweb_config.h"
+
#include "app.hpp"
#include "async_resp.hpp"
#include "dbus_utility.hpp"
+#include "error_messages.hpp"
#include "http_request.hpp"
-#include "privileges.hpp"
+#include "logging.hpp"
#include "query.hpp"
#include "registries/privilege_registry.hpp"
-#include "routing.hpp"
+#include <boost/asio/error.hpp>
+#include <boost/beast/http/verb.hpp>
#include <boost/system/error_code.hpp>
#include <boost/system/linux_error.hpp>
#include <boost/url/format.hpp>
#include <nlohmann/json.hpp>
-#include <sdbusplus/asio/property.hpp>
+#include <chrono>
+#include <cmath>
+#include <cstdint>
#include <functional>
-#include <limits>
#include <memory>
+#include <ratio>
+#include <source_location>
#include <string>
namespace redfish
diff --git a/redfish-core/lib/manager_logservices_journal.hpp b/redfish-core/lib/manager_logservices_journal.hpp
index 7feeaf3..1508ace 100644
--- a/redfish-core/lib/manager_logservices_journal.hpp
+++ b/redfish-core/lib/manager_logservices_journal.hpp
@@ -2,23 +2,34 @@
// SPDX-FileCopyrightText: Copyright OpenBMC Authors
#pragma once
+#include "bmcweb_config.h"
+
#include "app.hpp"
+#include "async_resp.hpp"
+#include "dbus_singleton.hpp"
#include "error_messages.hpp"
-#include "generated/enums/log_entry.hpp"
+#include "http_request.hpp"
+#include "logging.hpp"
#include "query.hpp"
-#include "registries/base_message_registry.hpp"
#include "registries/privilege_registry.hpp"
+#include "utility.hpp"
#include "utils/journal_utils.hpp"
+#include "utils/query_param.hpp"
#include "utils/time_utils.hpp"
#include <systemd/sd-journal.h>
+#include <boost/asio/post.hpp>
#include <boost/beast/http/verb.hpp>
+#include <boost/url/format.hpp>
-#include <array>
+#include <cstddef>
+#include <cstdint>
+#include <functional>
#include <memory>
#include <string>
#include <string_view>
+#include <utility>
namespace redfish
{
diff --git a/redfish-core/lib/managers.hpp b/redfish-core/lib/managers.hpp
index fca5fc5..33c992c 100644
--- a/redfish-core/lib/managers.hpp
+++ b/redfish-core/lib/managers.hpp
@@ -6,10 +6,16 @@
#include "bmcweb_config.h"
#include "app.hpp"
+#include "async_resp.hpp"
+#include "dbus_singleton.hpp"
#include "dbus_utility.hpp"
+#include "error_messages.hpp"
#include "generated/enums/action_info.hpp"
#include "generated/enums/manager.hpp"
#include "generated/enums/resource.hpp"
+#include "http_request.hpp"
+#include "logging.hpp"
+#include "persistent_data.hpp"
#include "query.hpp"
#include "redfish_util.hpp"
#include "registries/privilege_registry.hpp"
@@ -19,21 +25,37 @@
#include "utils/systemd_utils.hpp"
#include "utils/time_utils.hpp"
+#include <systemd/sd-bus.h>
+
+#include <boost/asio/post.hpp>
+#include <boost/beast/http/status.hpp>
+#include <boost/beast/http/verb.hpp>
+#include <boost/container/flat_map.hpp>
+#include <boost/container/flat_set.hpp>
#include <boost/system/error_code.hpp>
#include <boost/url/format.hpp>
+#include <boost/url/url.hpp>
+#include <nlohmann/json.hpp>
#include <sdbusplus/asio/property.hpp>
+#include <sdbusplus/message.hpp>
+#include <sdbusplus/message/native_types.hpp>
#include <sdbusplus/unpack_properties.hpp>
#include <algorithm>
#include <array>
+#include <cstddef>
#include <cstdint>
+#include <format>
+#include <functional>
+#include <map>
#include <memory>
#include <optional>
#include <ranges>
-#include <sstream>
#include <string>
#include <string_view>
+#include <utility>
#include <variant>
+#include <vector>
namespace redfish
{
diff --git a/redfish-core/lib/memory.hpp b/redfish-core/lib/memory.hpp
index 5ea0f4e..e9ceb7f 100644
--- a/redfish-core/lib/memory.hpp
+++ b/redfish-core/lib/memory.hpp
@@ -6,24 +6,34 @@
#include "bmcweb_config.h"
#include "app.hpp"
+#include "async_resp.hpp"
#include "dbus_utility.hpp"
+#include "error_messages.hpp"
#include "generated/enums/memory.hpp"
#include "generated/enums/resource.hpp"
+#include "http_request.hpp"
+#include "logging.hpp"
#include "query.hpp"
#include "registries/privilege_registry.hpp"
#include "utils/collection.hpp"
#include "utils/dbus_utils.hpp"
#include "utils/hex_utils.hpp"
-#include "utils/json_utils.hpp"
+#include <boost/beast/http/verb.hpp>
#include <boost/system/error_code.hpp>
#include <boost/url/format.hpp>
#include <nlohmann/json.hpp>
-#include <sdbusplus/asio/property.hpp>
+#include <sdbusplus/message/native_types.hpp>
#include <sdbusplus/unpack_properties.hpp>
#include <array>
+#include <cstddef>
+#include <cstdint>
+#include <memory>
+#include <string>
#include <string_view>
+#include <utility>
+#include <vector>
namespace redfish
{
diff --git a/redfish-core/lib/message_registries.hpp b/redfish-core/lib/message_registries.hpp
index b8a3ebd..6bbdb48 100644
--- a/redfish-core/lib/message_registries.hpp
+++ b/redfish-core/lib/message_registries.hpp
@@ -4,14 +4,24 @@
#pragma once
#include "app.hpp"
+#include "async_resp.hpp"
+#include "error_messages.hpp"
+#include "http_request.hpp"
#include "query.hpp"
#include "registries.hpp"
+#include "registries/privilege_registry.hpp"
#include "registries_selector.hpp"
+#include <boost/beast/http/verb.hpp>
#include <boost/url/format.hpp>
#include <array>
#include <format>
+#include <functional>
+#include <memory>
+#include <optional>
+#include <span>
+#include <utility>
namespace redfish
{
diff --git a/redfish-core/lib/metadata.hpp b/redfish-core/lib/metadata.hpp
index 049868e..55a9c91 100644
--- a/redfish-core/lib/metadata.hpp
+++ b/redfish-core/lib/metadata.hpp
@@ -2,19 +2,24 @@
// SPDX-FileCopyrightText: Copyright OpenBMC Authors
#pragma once
-#include "bmcweb_config.h"
-
#include "app.hpp"
#include "async_resp.hpp"
#include "http_request.hpp"
-#include "persistent_data.hpp"
-#include "query.hpp"
-#include "registries/privilege_registry.hpp"
-#include "utils/systemd_utils.hpp"
+#include "logging.hpp"
#include <tinyxml2.h>
-#include <nlohmann/json.hpp>
+#include <boost/beast/http/field.hpp>
+#include <boost/beast/http/status.hpp>
+#include <boost/beast/http/verb.hpp>
+
+#include <filesystem>
+#include <format>
+#include <functional>
+#include <memory>
+#include <string>
+#include <system_error>
+#include <utility>
namespace redfish
{
diff --git a/redfish-core/lib/metric_report.hpp b/redfish-core/lib/metric_report.hpp
index c53bee2..5312950 100644
--- a/redfish-core/lib/metric_report.hpp
+++ b/redfish-core/lib/metric_report.hpp
@@ -3,18 +3,33 @@
#pragma once
#include "app.hpp"
-#include "dbus_utility.hpp"
+#include "async_resp.hpp"
+#include "dbus_singleton.hpp"
+#include "error_messages.hpp"
+#include "http_request.hpp"
+#include "logging.hpp"
#include "query.hpp"
#include "registries/privilege_registry.hpp"
#include "utils/collection.hpp"
#include "utils/telemetry_utils.hpp"
#include "utils/time_utils.hpp"
+#include <asm-generic/errno.h>
+
+#include <boost/beast/http/verb.hpp>
#include <boost/url/format.hpp>
+#include <boost/url/url.hpp>
+#include <nlohmann/json.hpp>
#include <sdbusplus/asio/property.hpp>
#include <array>
+#include <cstdint>
+#include <memory>
+#include <string>
#include <string_view>
+#include <tuple>
+#include <utility>
+#include <vector>
namespace redfish
{
diff --git a/redfish-core/lib/metric_report_definition.hpp b/redfish-core/lib/metric_report_definition.hpp
index 8bdd8e3..d6c7541 100644
--- a/redfish-core/lib/metric_report_definition.hpp
+++ b/redfish-core/lib/metric_report_definition.hpp
@@ -3,9 +3,15 @@
#pragma once
#include "app.hpp"
+#include "async_resp.hpp"
+#include "dbus_singleton.hpp"
#include "dbus_utility.hpp"
+#include "error_messages.hpp"
#include "generated/enums/metric_report_definition.hpp"
#include "generated/enums/resource.hpp"
+#include "http_request.hpp"
+#include "http_response.hpp"
+#include "logging.hpp"
#include "query.hpp"
#include "registries/privilege_registry.hpp"
#include "sensors.hpp"
@@ -15,13 +21,30 @@
#include "utils/telemetry_utils.hpp"
#include "utils/time_utils.hpp"
+#include <asm-generic/errno.h>
+#include <systemd/sd-bus.h>
+
+#include <boost/asio/post.hpp>
+#include <boost/beast/http/field.hpp>
+#include <boost/beast/http/status.hpp>
+#include <boost/beast/http/verb.hpp>
#include <boost/container/flat_map.hpp>
+#include <boost/container/flat_set.hpp>
#include <boost/url/format.hpp>
-#include <sdbusplus/asio/property.hpp>
+#include <boost/url/url.hpp>
+#include <nlohmann/json.hpp>
+#include <sdbusplus/message.hpp>
+#include <sdbusplus/message/native_types.hpp>
#include <sdbusplus/unpack_properties.hpp>
#include <array>
+#include <chrono>
+#include <cstddef>
+#include <cstdint>
+#include <functional>
+#include <limits>
#include <map>
+#include <memory>
#include <optional>
#include <span>
#include <string>
diff --git a/redfish-core/lib/network_protocol.hpp b/redfish-core/lib/network_protocol.hpp
index 5b6120e..637bdb5 100644
--- a/redfish-core/lib/network_protocol.hpp
+++ b/redfish-core/lib/network_protocol.hpp
@@ -3,23 +3,42 @@
// SPDX-FileCopyrightText: Copyright 2018 Intel Corporation
#pragma once
+#include "bmcweb_config.h"
+
#include "app.hpp"
+#include "async_resp.hpp"
+#include "dbus_singleton.hpp"
#include "dbus_utility.hpp"
#include "error_messages.hpp"
#include "generated/enums/resource.hpp"
+#include "http_request.hpp"
+#include "logging.hpp"
+#include "privileges.hpp"
#include "query.hpp"
#include "redfish_util.hpp"
#include "registries/privilege_registry.hpp"
+#include "utils/dbus_utils.hpp"
#include "utils/json_utils.hpp"
#include "utils/stl_utils.hpp"
+#include <unistd.h>
+
+#include <boost/beast/http/field.hpp>
+#include <boost/beast/http/status.hpp>
+#include <boost/beast/http/verb.hpp>
#include <boost/system/error_code.hpp>
#include <boost/url/format.hpp>
-#include <sdbusplus/asio/property.hpp>
+#include <sdbusplus/message/native_types.hpp>
#include <array>
+#include <cstddef>
+#include <functional>
+#include <memory>
#include <optional>
+#include <string>
#include <string_view>
+#include <tuple>
+#include <utility>
#include <variant>
#include <vector>
diff --git a/redfish-core/lib/odata.hpp b/redfish-core/lib/odata.hpp
index a310816..5aa62f2 100644
--- a/redfish-core/lib/odata.hpp
+++ b/redfish-core/lib/odata.hpp
@@ -3,20 +3,20 @@
#pragma once
#include "app.hpp"
-#include "error_messages.hpp"
+#include "async_resp.hpp"
#include "http_request.hpp"
#include "http_response.hpp"
-#include "query.hpp"
-#include "registries/privilege_registry.hpp"
-#include "utility.hpp"
+#include <boost/beast/http/verb.hpp>
#include <boost/url/format.hpp>
+#include <boost/url/url.hpp>
#include <nlohmann/json.hpp>
#include <memory>
#include <ranges>
#include <string>
#include <string_view>
+#include <utility>
namespace redfish
{
diff --git a/redfish-core/lib/pcie.hpp b/redfish-core/lib/pcie.hpp
index 75a20b3..db3b945 100644
--- a/redfish-core/lib/pcie.hpp
+++ b/redfish-core/lib/pcie.hpp
@@ -4,21 +4,43 @@
#pragma once
+#include "bmcweb_config.h"
+
#include "app.hpp"
+#include "async_resp.hpp"
#include "dbus_utility.hpp"
+#include "error_messages.hpp"
+#include "generated/enums/pcie_device.hpp"
+#include "generated/enums/pcie_slots.hpp"
#include "generated/enums/resource.hpp"
+#include "http_request.hpp"
+#include "logging.hpp"
#include "query.hpp"
#include "registries/privilege_registry.hpp"
-#include "utils/collection.hpp"
#include "utils/dbus_utils.hpp"
#include "utils/pcie_util.hpp"
-#include <boost/system/linux_error.hpp>
+#include <asm-generic/errno.h>
+
+#include <boost/beast/http/field.hpp>
+#include <boost/beast/http/verb.hpp>
#include <boost/url/format.hpp>
-#include <sdbusplus/asio/property.hpp>
#include <sdbusplus/unpack_properties.hpp>
+#include <array>
+#include <charconv>
+#include <cstddef>
+#include <cstdint>
+#include <format>
+#include <functional>
#include <limits>
+#include <memory>
+#include <optional>
+#include <string>
+#include <string_view>
+#include <system_error>
+#include <utility>
+#include <variant>
namespace redfish
{
diff --git a/redfish-core/lib/pcie_slots.hpp b/redfish-core/lib/pcie_slots.hpp
index fb39a57..ba036b1 100644
--- a/redfish-core/lib/pcie_slots.hpp
+++ b/redfish-core/lib/pcie_slots.hpp
@@ -3,23 +3,35 @@
#pragma once
#include "app.hpp"
+#include "async_resp.hpp"
#include "dbus_utility.hpp"
#include "error_messages.hpp"
+#include "generated/enums/pcie_device.hpp"
#include "generated/enums/pcie_slots.hpp"
+#include "http_request.hpp"
+#include "logging.hpp"
#include "query.hpp"
#include "registries/privilege_registry.hpp"
-#include "utility.hpp"
#include "utils/dbus_utils.hpp"
-#include "utils/json_utils.hpp"
#include "utils/pcie_util.hpp"
+#include <asm-generic/errno.h>
+
+#include <boost/beast/http/verb.hpp>
#include <boost/system/error_code.hpp>
#include <boost/url/format.hpp>
-#include <sdbusplus/asio/property.hpp>
+#include <nlohmann/json.hpp>
+#include <sdbusplus/message/native_types.hpp>
#include <sdbusplus/unpack_properties.hpp>
#include <array>
+#include <cstddef>
+#include <functional>
+#include <memory>
+#include <optional>
+#include <string>
#include <string_view>
+#include <utility>
namespace redfish
{
diff --git a/redfish-core/lib/power.hpp b/redfish-core/lib/power.hpp
index a221d72..68acd1a 100644
--- a/redfish-core/lib/power.hpp
+++ b/redfish-core/lib/power.hpp
@@ -6,20 +6,36 @@
#pragma once
#include "app.hpp"
+#include "async_resp.hpp"
#include "dbus_utility.hpp"
+#include "error_messages.hpp"
#include "generated/enums/power.hpp"
+#include "http_request.hpp"
+#include "logging.hpp"
#include "query.hpp"
#include "registries/privilege_registry.hpp"
#include "sensors.hpp"
#include "utils/chassis_utils.hpp"
+#include "utils/dbus_utils.hpp"
#include "utils/json_utils.hpp"
#include "utils/sensor_utils.hpp"
-#include <sdbusplus/asio/property.hpp>
+#include <boost/beast/http/verb.hpp>
+#include <nlohmann/json.hpp>
+#include <sdbusplus/message/native_types.hpp>
#include <array>
+#include <cmath>
+#include <cstddef>
+#include <cstdint>
+#include <functional>
+#include <memory>
+#include <optional>
#include <string>
#include <string_view>
+#include <unordered_map>
+#include <utility>
+#include <variant>
#include <vector>
namespace redfish
diff --git a/redfish-core/lib/power_subsystem.hpp b/redfish-core/lib/power_subsystem.hpp
index c792fc8..24baa89 100644
--- a/redfish-core/lib/power_subsystem.hpp
+++ b/redfish-core/lib/power_subsystem.hpp
@@ -3,17 +3,23 @@
#pragma once
#include "app.hpp"
+#include "async_resp.hpp"
+#include "error_messages.hpp"
#include "generated/enums/resource.hpp"
-#include "logging.hpp"
+#include "http_request.hpp"
#include "query.hpp"
#include "registries/privilege_registry.hpp"
#include "utils/chassis_utils.hpp"
+#include <boost/beast/http/field.hpp>
+#include <boost/beast/http/verb.hpp>
#include <boost/url/format.hpp>
+#include <functional>
#include <memory>
#include <optional>
#include <string>
+#include <utility>
namespace redfish
{
diff --git a/redfish-core/lib/power_supply.hpp b/redfish-core/lib/power_supply.hpp
index a13f3f1..75c58eb 100644
--- a/redfish-core/lib/power_supply.hpp
+++ b/redfish-core/lib/power_supply.hpp
@@ -3,21 +3,35 @@
#pragma once
#include "app.hpp"
+#include "async_resp.hpp"
#include "dbus_utility.hpp"
+#include "error_messages.hpp"
#include "generated/enums/resource.hpp"
+#include "http_request.hpp"
+#include "logging.hpp"
#include "query.hpp"
#include "registries/privilege_registry.hpp"
#include "utils/chassis_utils.hpp"
#include "utils/dbus_utils.hpp"
-#include "utils/json_utils.hpp"
#include "utils/time_utils.hpp"
+#include <asm-generic/errno.h>
+
+#include <boost/beast/http/field.hpp>
+#include <boost/beast/http/verb.hpp>
#include <boost/system/error_code.hpp>
#include <boost/url/format.hpp>
+#include <nlohmann/json.hpp>
+#include <sdbusplus/unpack_properties.hpp>
+#include <array>
+#include <cstdint>
+#include <functional>
#include <memory>
#include <optional>
#include <string>
+#include <string_view>
+#include <utility>
namespace redfish
{
diff --git a/redfish-core/lib/processor.hpp b/redfish-core/lib/processor.hpp
index 73b0997..b07f86c 100644
--- a/redfish-core/lib/processor.hpp
+++ b/redfish-core/lib/processor.hpp
@@ -3,31 +3,46 @@
// SPDX-FileCopyrightText: Copyright 2018 Intel Corporation
#pragma once
+#include "bmcweb_config.h"
+
#include "app.hpp"
-#include "dbus_singleton.hpp"
+#include "async_resp.hpp"
#include "dbus_utility.hpp"
#include "error_messages.hpp"
#include "generated/enums/processor.hpp"
#include "generated/enums/resource.hpp"
+#include "http_request.hpp"
+#include "logging.hpp"
#include "query.hpp"
#include "registries/privilege_registry.hpp"
#include "utils/collection.hpp"
#include "utils/dbus_utils.hpp"
+#include "utils/hex_utils.hpp"
#include "utils/json_utils.hpp"
-#include <boost/container/flat_map.hpp>
+#include <boost/beast/http/field.hpp>
+#include <boost/beast/http/verb.hpp>
#include <boost/system/error_code.hpp>
#include <boost/url/format.hpp>
-#include <sdbusplus/asio/property.hpp>
#include <sdbusplus/message/native_types.hpp>
#include <sdbusplus/unpack_properties.hpp>
-#include <sdbusplus/utility/dedup_variant.hpp>
+#include <algorithm>
#include <array>
+#include <cstddef>
+#include <cstdint>
+#include <format>
+#include <functional>
#include <limits>
+#include <memory>
+#include <optional>
#include <ranges>
#include <string>
#include <string_view>
+#include <tuple>
+#include <utility>
+#include <variant>
+#include <vector>
namespace redfish
{
diff --git a/redfish-core/lib/redfish_sessions.hpp b/redfish-core/lib/redfish_sessions.hpp
index 4561f52..40b946f 100644
--- a/redfish-core/lib/redfish_sessions.hpp
+++ b/redfish-core/lib/redfish_sessions.hpp
@@ -5,17 +5,33 @@
#include "account_service.hpp"
#include "app.hpp"
+#include "async_resp.hpp"
#include "cookies.hpp"
+#include "dbus_privileges.hpp"
#include "error_messages.hpp"
-#include "http/utility.hpp"
-#include "persistent_data.hpp"
+#include "http_request.hpp"
+#include "http_response.hpp"
+#include "pam_authenticate.hpp"
+#include "privileges.hpp"
#include "query.hpp"
#include "registries/privilege_registry.hpp"
+#include "sessions.hpp"
#include "utils/json_utils.hpp"
+#include <security/_pam_types.h>
+
+#include <boost/beast/http/field.hpp>
+#include <boost/beast/http/status.hpp>
+#include <boost/beast/http/verb.hpp>
#include <boost/url/format.hpp>
+#include <chrono>
+#include <cstdint>
+#include <functional>
+#include <memory>
+#include <optional>
#include <string>
+#include <utility>
#include <vector>
namespace redfish
diff --git a/redfish-core/lib/redfish_util.hpp b/redfish-core/lib/redfish_util.hpp
index 1f7c4ba..aa0d861 100644
--- a/redfish-core/lib/redfish_util.hpp
+++ b/redfish-core/lib/redfish_util.hpp
@@ -4,16 +4,29 @@
#pragma once
#include "async_resp.hpp"
+#include "dbus_singleton.hpp"
#include "dbus_utility.hpp"
#include "error_messages.hpp"
+#include "logging.hpp"
+#include <boost/system/errc.hpp>
#include <boost/system/error_code.hpp>
-#include <sdbusplus/asio/property.hpp>
+#include <sdbusplus/message/native_types.hpp>
+#include <algorithm>
#include <array>
#include <charconv>
+#include <cstddef>
+#include <cstdint>
+#include <memory>
#include <ranges>
+#include <span>
+#include <string>
#include <string_view>
+#include <system_error>
+#include <tuple>
+#include <utility>
+#include <vector>
namespace redfish
{
diff --git a/redfish-core/lib/redfish_v1.hpp b/redfish-core/lib/redfish_v1.hpp
index 8d2712a..44d4331 100644
--- a/redfish-core/lib/redfish_v1.hpp
+++ b/redfish-core/lib/redfish_v1.hpp
@@ -3,17 +3,30 @@
#pragma once
#include "app.hpp"
+#include "async_resp.hpp"
#include "error_messages.hpp"
#include "http_request.hpp"
#include "http_response.hpp"
+#include "logging.hpp"
#include "query.hpp"
#include "registries/privilege_registry.hpp"
-#include "utility.hpp"
+#include "str_utility.hpp"
+#include <boost/beast/http/field.hpp>
+#include <boost/beast/http/status.hpp>
+#include <boost/beast/http/verb.hpp>
#include <boost/url/format.hpp>
+#include <array>
+#include <filesystem>
+#include <format>
+#include <functional>
+#include <memory>
#include <ranges>
#include <string>
+#include <system_error>
+#include <utility>
+#include <vector>
namespace redfish
{
diff --git a/redfish-core/lib/roles.hpp b/redfish-core/lib/roles.hpp
index 98f7085..65b5242 100644
--- a/redfish-core/lib/roles.hpp
+++ b/redfish-core/lib/roles.hpp
@@ -4,17 +4,23 @@
#pragma once
#include "app.hpp"
+#include "async_resp.hpp"
#include "dbus_utility.hpp"
+#include "error_messages.hpp"
+#include "http_request.hpp"
#include "query.hpp"
#include "registries/privilege_registry.hpp"
+#include <boost/beast/http/verb.hpp>
#include <boost/url/format.hpp>
#include <nlohmann/json.hpp>
-#include <sdbusplus/asio/property.hpp>
+#include <memory>
#include <optional>
+#include <string>
#include <string_view>
-#include <variant>
+#include <utility>
+#include <vector>
namespace redfish
{
diff --git a/redfish-core/lib/sensors.hpp b/redfish-core/lib/sensors.hpp
index fe5d1ee..6fe08df 100644
--- a/redfish-core/lib/sensors.hpp
+++ b/redfish-core/lib/sensors.hpp
@@ -3,11 +3,17 @@
// SPDX-FileCopyrightText: Copyright 2018 Intel Corporation
#pragma once
+#include "bmcweb_config.h"
+
#include "app.hpp"
+#include "async_resp.hpp"
#include "dbus_singleton.hpp"
#include "dbus_utility.hpp"
+#include "error_messages.hpp"
#include "generated/enums/redundancy.hpp"
#include "generated/enums/resource.hpp"
+#include "http_request.hpp"
+#include "logging.hpp"
#include "query.hpp"
#include "registries/privilege_registry.hpp"
#include "str_utility.hpp"
@@ -16,22 +22,36 @@
#include "utils/query_param.hpp"
#include "utils/sensor_utils.hpp"
+#include <asm-generic/errno.h>
+
+#include <boost/beast/http/status.hpp>
+#include <boost/beast/http/verb.hpp>
#include <boost/system/error_code.hpp>
#include <boost/url/format.hpp>
-#include <sdbusplus/asio/property.hpp>
+#include <boost/url/url.hpp>
+#include <nlohmann/json.hpp>
+#include <sdbusplus/message/native_types.hpp>
#include <sdbusplus/unpack_properties.hpp>
+#include <algorithm>
#include <array>
#include <cmath>
+#include <cstddef>
+#include <cstdint>
+#include <functional>
#include <iterator>
-#include <limits>
#include <map>
+#include <memory>
+#include <optional>
#include <ranges>
#include <set>
+#include <span>
#include <string>
#include <string_view>
+#include <unordered_map>
#include <utility>
#include <variant>
+#include <vector>
namespace redfish
{
diff --git a/redfish-core/lib/service_root.hpp b/redfish-core/lib/service_root.hpp
index 5e3bbad..2923c54 100644
--- a/redfish-core/lib/service_root.hpp
+++ b/redfish-core/lib/service_root.hpp
@@ -11,10 +11,16 @@
#include "persistent_data.hpp"
#include "query.hpp"
#include "registries/privilege_registry.hpp"
-#include "utils/systemd_utils.hpp"
+#include <boost/beast/http/field.hpp>
+#include <boost/beast/http/verb.hpp>
+#include <boost/url/format.hpp>
#include <nlohmann/json.hpp>
+#include <functional>
+#include <memory>
+#include <string>
+
namespace redfish
{
diff --git a/redfish-core/lib/storage.hpp b/redfish-core/lib/storage.hpp
index 22587da..27db3aa 100644
--- a/redfish-core/lib/storage.hpp
+++ b/redfish-core/lib/storage.hpp
@@ -6,25 +6,40 @@
#include "bmcweb_config.h"
#include "app.hpp"
+#include "async_resp.hpp"
#include "dbus_utility.hpp"
+#include "error_messages.hpp"
#include "generated/enums/drive.hpp"
#include "generated/enums/protocol.hpp"
#include "generated/enums/resource.hpp"
+#include "http_request.hpp"
#include "human_sort.hpp"
+#include "logging.hpp"
#include "query.hpp"
#include "redfish_util.hpp"
#include "registries/privilege_registry.hpp"
#include "utils/collection.hpp"
#include "utils/dbus_utils.hpp"
+#include <boost/beast/http/verb.hpp>
#include <boost/system/error_code.hpp>
#include <boost/url/format.hpp>
-#include <sdbusplus/asio/property.hpp>
+#include <sdbusplus/message/native_types.hpp>
#include <sdbusplus/unpack_properties.hpp>
+#include <algorithm>
#include <array>
+#include <cstdint>
+#include <format>
+#include <functional>
+#include <memory>
+#include <optional>
#include <ranges>
+#include <string>
#include <string_view>
+#include <utility>
+#include <variant>
+#include <vector>
namespace redfish
{
diff --git a/redfish-core/lib/systems.hpp b/redfish-core/lib/systems.hpp
index b86461f..129c59a 100644
--- a/redfish-core/lib/systems.hpp
+++ b/redfish-core/lib/systems.hpp
@@ -6,14 +6,18 @@
#include "bmcweb_config.h"
#include "app.hpp"
+#include "async_resp.hpp"
#include "dbus_singleton.hpp"
#include "dbus_utility.hpp"
+#include "error_messages.hpp"
#include "generated/enums/action_info.hpp"
#include "generated/enums/computer_system.hpp"
#include "generated/enums/open_bmc_computer_system.hpp"
#include "generated/enums/resource.hpp"
+#include "http_request.hpp"
#include "hypervisor_system.hpp"
#include "led.hpp"
+#include "logging.hpp"
#include "query.hpp"
#include "redfish_util.hpp"
#include "registries/privilege_registry.hpp"
@@ -23,21 +27,31 @@
#include "utils/sw_utils.hpp"
#include "utils/time_utils.hpp"
+#include <asm-generic/errno.h>
+
#include <boost/asio/error.hpp>
-#include <boost/container/flat_map.hpp>
+#include <boost/beast/http/field.hpp>
+#include <boost/beast/http/status.hpp>
+#include <boost/beast/http/verb.hpp>
#include <boost/system/error_code.hpp>
#include <boost/system/linux_error.hpp>
#include <boost/url/format.hpp>
-#include <sdbusplus/asio/property.hpp>
-#include <sdbusplus/message.hpp>
+#include <nlohmann/json.hpp>
+#include <sdbusplus/message/native_types.hpp>
#include <sdbusplus/unpack_properties.hpp>
#include <array>
+#include <chrono>
+#include <cstddef>
+#include <cstdint>
+#include <functional>
#include <memory>
+#include <optional>
+#include <ratio>
#include <string>
#include <string_view>
+#include <tuple>
#include <utility>
-#include <variant>
#include <vector>
namespace redfish
diff --git a/redfish-core/lib/systems_logservices_hostlogger.hpp b/redfish-core/lib/systems_logservices_hostlogger.hpp
index 7e9a7b7..701695d 100644
--- a/redfish-core/lib/systems_logservices_hostlogger.hpp
+++ b/redfish-core/lib/systems_logservices_hostlogger.hpp
@@ -2,18 +2,35 @@
// SPDX-FileCopyrightText: Copyright OpenBMC Authors
#pragma once
+#include "bmcweb_config.h"
+
#include "app.hpp"
+#include "async_resp.hpp"
+#include "error_messages.hpp"
#include "generated/enums/log_entry.hpp"
#include "gzfile.hpp"
-#include "human_sort.hpp""
+#include "http_request.hpp"
+#include "human_sort.hpp"
+#include "logging.hpp"
#include "query.hpp"
-#include "registries/openbmc_message_registry.hpp"
#include "registries/privilege_registry.hpp"
-#include "utils/time_utils.hpp"
+#include "utils/query_param.hpp"
+#include <boost/beast/http/verb.hpp>
+#include <boost/url/format.hpp>
+#include <nlohmann/json.hpp>
+
+#include <algorithm>
+#include <charconv>
+#include <cstddef>
#include <cstdint>
+#include <filesystem>
+#include <format>
+#include <functional>
#include <memory>
+#include <string>
#include <string_view>
+#include <system_error>
#include <utility>
#include <vector>
diff --git a/redfish-core/lib/systems_logservices_postcodes.hpp b/redfish-core/lib/systems_logservices_postcodes.hpp
index e77f6f0..84bd112 100644
--- a/redfish-core/lib/systems_logservices_postcodes.hpp
+++ b/redfish-core/lib/systems_logservices_postcodes.hpp
@@ -2,17 +2,49 @@
// SPDX-FileCopyrightText: Copyright OpenBMC Authors
#pragma once
+#include "bmcweb_config.h"
+
#include "app.hpp"
+#include "async_resp.hpp"
+#include "dbus_singleton.hpp"
#include "dbus_utility.hpp"
+#include "error_messages.hpp"
#include "generated/enums/log_service.hpp"
+#include "http_request.hpp"
+#include "http_utility.hpp"
+#include "logging.hpp"
#include "query.hpp"
-#include "registries/openbmc_message_registry.hpp"
+#include "registries.hpp"
#include "registries/privilege_registry.hpp"
+#include "str_utility.hpp"
+#include "utility.hpp"
+#include "utils/hex_utils.hpp"
+#include "utils/query_param.hpp"
#include "utils/time_utils.hpp"
+#include <asm-generic/errno.h>
+
+#include <boost/beast/http/field.hpp>
+#include <boost/beast/http/status.hpp>
+#include <boost/beast/http/verb.hpp>
+#include <boost/container/flat_map.hpp>
+#include <boost/url/format.hpp>
+
+#include <algorithm>
+#include <array>
+#include <charconv>
+#include <cstddef>
#include <cstdint>
+#include <format>
+#include <functional>
+#include <iomanip>
+#include <ios>
#include <memory>
+#include <sstream>
+#include <string>
#include <string_view>
+#include <system_error>
+#include <tuple>
#include <utility>
#include <vector>
diff --git a/redfish-core/lib/task.hpp b/redfish-core/lib/task.hpp
index a80d03b..40aaffd 100644
--- a/redfish-core/lib/task.hpp
+++ b/redfish-core/lib/task.hpp
@@ -4,24 +4,47 @@
#pragma once
#include "app.hpp"
-#include "dbus_utility.hpp"
+#include "async_resp.hpp"
+#include "dbus_singleton.hpp"
+#include "error_messages.hpp"
#include "event_service_manager.hpp"
#include "generated/enums/resource.hpp"
#include "generated/enums/task_service.hpp"
#include "http/parsing.hpp"
+#include "http_request.hpp"
+#include "http_response.hpp"
+#include "logging.hpp"
#include "query.hpp"
#include "registries/privilege_registry.hpp"
#include "task_messages.hpp"
+#include "utils/time_utils.hpp"
+#include <boost/asio/error.hpp>
#include <boost/asio/post.hpp>
#include <boost/asio/steady_timer.hpp>
+#include <boost/beast/http/field.hpp>
+#include <boost/beast/http/status.hpp>
+#include <boost/beast/http/verb.hpp>
#include <boost/url/format.hpp>
+#include <boost/url/url.hpp>
+#include <nlohmann/json.hpp>
+#include <sdbusplus/bus.hpp>
#include <sdbusplus/bus/match.hpp>
+#include <sdbusplus/message.hpp>
+#include <algorithm>
+#include <array>
#include <chrono>
+#include <cstddef>
+#include <ctime>
+#include <deque>
+#include <functional>
#include <memory>
+#include <optional>
#include <ranges>
-#include <variant>
+#include <string>
+#include <string_view>
+#include <utility>
namespace redfish
{
diff --git a/redfish-core/lib/telemetry_service.hpp b/redfish-core/lib/telemetry_service.hpp
index ab0abe0..49d4673 100644
--- a/redfish-core/lib/telemetry_service.hpp
+++ b/redfish-core/lib/telemetry_service.hpp
@@ -3,17 +3,29 @@
#pragma once
#include "app.hpp"
+#include "async_resp.hpp"
#include "dbus_utility.hpp"
+#include "error_messages.hpp"
#include "generated/enums/resource.hpp"
+#include "http_request.hpp"
+#include "logging.hpp"
#include "query.hpp"
#include "registries/privilege_registry.hpp"
#include "utils/dbus_utils.hpp"
#include "utils/telemetry_utils.hpp"
#include "utils/time_utils.hpp"
-#include <sdbusplus/asio/property.hpp>
+#include <boost/beast/http/verb.hpp>
#include <sdbusplus/unpack_properties.hpp>
+#include <chrono>
+#include <cstddef>
+#include <cstdint>
+#include <ctime>
+#include <functional>
+#include <memory>
+#include <utility>
+
namespace redfish
{
diff --git a/redfish-core/lib/thermal.hpp b/redfish-core/lib/thermal.hpp
index 1b5b1f1..8417dba 100644
--- a/redfish-core/lib/thermal.hpp
+++ b/redfish-core/lib/thermal.hpp
@@ -4,12 +4,24 @@
#pragma once
#include "app.hpp"
+#include "async_resp.hpp"
+#include "error_messages.hpp"
+#include "http_request.hpp"
#include "query.hpp"
#include "registries/privilege_registry.hpp"
#include "sensors.hpp"
#include "utils/json_utils.hpp"
#include "utils/sensor_utils.hpp"
+#include <boost/beast/http/verb.hpp>
+#include <nlohmann/json.hpp>
+
+#include <memory>
+#include <optional>
+#include <unordered_map>
+#include <utility>
+#include <vector>
+
namespace redfish
{
diff --git a/redfish-core/lib/thermal_metrics.hpp b/redfish-core/lib/thermal_metrics.hpp
index 638a7f5..b2ddec7 100644
--- a/redfish-core/lib/thermal_metrics.hpp
+++ b/redfish-core/lib/thermal_metrics.hpp
@@ -3,14 +3,25 @@
#pragma once
#include "app.hpp"
+#include "async_resp.hpp"
+#include "dbus_singleton.hpp"
#include "dbus_utility.hpp"
+#include "error_messages.hpp"
+#include "http_request.hpp"
+#include "logging.hpp"
#include "query.hpp"
#include "registries/privilege_registry.hpp"
#include "utils/chassis_utils.hpp"
#include "utils/json_utils.hpp"
#include "utils/sensor_utils.hpp"
+#include <asm-generic/errno.h>
+
+#include <boost/beast/http/field.hpp>
+#include <boost/beast/http/verb.hpp>
#include <boost/system/error_code.hpp>
+#include <boost/url/format.hpp>
+#include <nlohmann/json.hpp>
#include <array>
#include <functional>
@@ -18,6 +29,7 @@
#include <optional>
#include <string>
#include <string_view>
+#include <utility>
namespace redfish
{
diff --git a/redfish-core/lib/thermal_subsystem.hpp b/redfish-core/lib/thermal_subsystem.hpp
index 81407bd..9574228 100644
--- a/redfish-core/lib/thermal_subsystem.hpp
+++ b/redfish-core/lib/thermal_subsystem.hpp
@@ -3,15 +3,21 @@
#pragma once
#include "app.hpp"
+#include "async_resp.hpp"
+#include "error_messages.hpp"
#include "generated/enums/resource.hpp"
+#include "http_request.hpp"
#include "logging.hpp"
#include "query.hpp"
#include "registries/privilege_registry.hpp"
#include "utils/chassis_utils.hpp"
-#include "utils/json_utils.hpp"
+#include <boost/beast/http/field.hpp>
+#include <boost/beast/http/verb.hpp>
#include <boost/url/format.hpp>
+#include <functional>
+#include <memory>
#include <optional>
#include <string>
diff --git a/redfish-core/lib/trigger.hpp b/redfish-core/lib/trigger.hpp
index 2d5fe13..c15520e 100644
--- a/redfish-core/lib/trigger.hpp
+++ b/redfish-core/lib/trigger.hpp
@@ -3,9 +3,16 @@
#pragma once
#include "app.hpp"
+#include "async_resp.hpp"
+#include "dbus_singleton.hpp"
+#include "dbus_utility.hpp"
+#include "error_messages.hpp"
#include "generated/enums/metric_definition.hpp"
#include "generated/enums/resource.hpp"
#include "generated/enums/triggers.hpp"
+#include "http_request.hpp"
+#include "http_response.hpp"
+#include "logging.hpp"
#include "query.hpp"
#include "registries/privilege_registry.hpp"
#include "utility.hpp"
@@ -16,14 +23,31 @@
#include "utils/telemetry_utils.hpp"
#include "utils/time_utils.hpp"
+#include <asm-generic/errno.h>
+
+#include <boost/beast/http/status.hpp>
+#include <boost/beast/http/verb.hpp>
+#include <boost/system/result.hpp>
#include <boost/url/format.hpp>
+#include <boost/url/parse.hpp>
+#include <boost/url/url.hpp>
+#include <boost/url/url_view.hpp>
+#include <nlohmann/json.hpp>
#include <sdbusplus/asio/property.hpp>
+#include <sdbusplus/message/native_types.hpp>
#include <sdbusplus/unpack_properties.hpp>
#include <array>
+#include <chrono>
+#include <cstddef>
+#include <cstdint>
+#include <functional>
+#include <memory>
+#include <optional>
+#include <string>
#include <string_view>
#include <tuple>
-#include <variant>
+#include <utility>
#include <vector>
namespace redfish
diff --git a/redfish-core/lib/update_service.hpp b/redfish-core/lib/update_service.hpp
index 3d804d7..a5bbf9a 100644
--- a/redfish-core/lib/update_service.hpp
+++ b/redfish-core/lib/update_service.hpp
@@ -6,38 +6,65 @@
#include "bmcweb_config.h"
#include "app.hpp"
+#include "async_resp.hpp"
+#include "dbus_singleton.hpp"
#include "dbus_utility.hpp"
#include "error_messages.hpp"
+#include "generated/enums/resource.hpp"
#include "generated/enums/update_service.hpp"
+#include "http_request.hpp"
+#include "http_response.hpp"
+#include "logging.hpp"
#include "multipart_parser.hpp"
#include "ossl_random.hpp"
#include "query.hpp"
#include "registries/privilege_registry.hpp"
+#include "str_utility.hpp"
#include "task.hpp"
#include "task_messages.hpp"
+#include "utility.hpp"
#include "utils/collection.hpp"
#include "utils/dbus_utils.hpp"
#include "utils/json_utils.hpp"
#include "utils/sw_utils.hpp"
#include <sys/mman.h>
+#include <unistd.h>
+#include <boost/asio/error.hpp>
+#include <boost/asio/steady_timer.hpp>
+#include <boost/beast/http/fields.hpp>
+#include <boost/beast/http/status.hpp>
+#include <boost/beast/http/verb.hpp>
#include <boost/system/error_code.hpp>
+#include <boost/system/result.hpp>
#include <boost/url/format.hpp>
+#include <boost/url/parse.hpp>
+#include <boost/url/url.hpp>
+#include <boost/url/url_view.hpp>
+#include <boost/url/url_view_base.hpp>
#include <sdbusplus/asio/property.hpp>
#include <sdbusplus/bus/match.hpp>
+#include <sdbusplus/message.hpp>
+#include <sdbusplus/message/native_types.hpp>
#include <sdbusplus/unpack_properties.hpp>
#include <array>
+#include <chrono>
#include <cstddef>
+#include <cstdint>
+#include <cstdio>
#include <filesystem>
+#include <format>
+#include <fstream>
#include <functional>
-#include <iterator>
#include <memory>
#include <optional>
#include <string>
#include <string_view>
#include <unordered_map>
+#include <utility>
+#include <variant>
#include <vector>
namespace redfish
diff --git a/redfish-core/lib/virtual_media.hpp b/redfish-core/lib/virtual_media.hpp
index be0d58e..fbdcb94 100644
--- a/redfish-core/lib/virtual_media.hpp
+++ b/redfish-core/lib/virtual_media.hpp
@@ -3,23 +3,38 @@
// SPDX-FileCopyrightText: Copyright 2018 Intel Corporation
#pragma once
-#include "account_service.hpp"
#include "app.hpp"
#include "async_resp.hpp"
#include "credential_pipe.hpp"
+#include "dbus_singleton.hpp"
#include "dbus_utility.hpp"
+#include "error_messages.hpp"
#include "generated/enums/virtual_media.hpp"
+#include "http_request.hpp"
+#include "logging.hpp"
#include "query.hpp"
#include "registries/privilege_registry.hpp"
#include "utils/json_utils.hpp"
+#include <boost/beast/http/status.hpp>
+#include <boost/beast/http/verb.hpp>
+#include <boost/system/result.hpp>
#include <boost/url/format.hpp>
+#include <boost/url/parse.hpp>
#include <boost/url/url_view.hpp>
#include <boost/url/url_view_base.hpp>
+#include <sdbusplus/message/native_types.hpp>
-#include <array>
+#include <cstddef>
+#include <filesystem>
+#include <functional>
+#include <memory>
+#include <optional>
#include <ranges>
+#include <string>
#include <string_view>
+#include <utility>
+#include <variant>
namespace redfish
{