commit db0d36efc8d4ddd8fc604b9e9d10963d19b1dae0
author Ed Tanous <edtanous@google.com> Fri Jun 30 10:37:05 2023 -0700
committer Ed Tanous <ed@tanous.net> Mon Jul 10 21:03:22 2023 +0000
tree 4471933a4223b48e747d6a62ea61acbca4d1190e
parent 0f83707d6f05640eeff012500ebe66a1b8020df5

Add contains type tidy check

On general container usage, contains() is more descriptive than count()
> 0.  We have one violation of this, fix it and enable the check.

Tested: Clang-tidy passes.

Change-Id: Ib5702ef97c6da033b6587c9cfebbe30dfbfe80b4
Signed-off-by: Ed Tanous <edtanous@google.com>

.clang-tidy

diff --git a/.clang-tidy b/.clang-tidy
index 308c3f9..ffa6589 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -280,6 +280,7 @@
 readability-avoid-const-params-in-decls,
 readability-braces-around-statements,
 readability-const-return-type,
+readability-container-contains,
 readability-container-data-pointer,
 readability-container-size-empty,
 readability-convert-member-functions-to-static,

redfish-core/lib/sensors.hpp

diff --git a/redfish-core/lib/sensors.hpp b/redfish-core/lib/sensors.hpp
index b5d0127..1fec868 100644
--- a/redfish-core/lib/sensors.hpp
+++ b/redfish-core/lib/sensors.hpp
@@ -1230,7 +1230,7 @@
 {
     for (InventoryItem& inventoryItem : *inventoryItems)
     {
-        if (inventoryItem.sensors.count(sensorObjPath) > 0)
+        if (inventoryItem.sensors.contains(sensorObjPath))
         {
             return &inventoryItem;
         }