commit dc2f9f11e726c02667e1c35080b15b20a4e62b33
author Matt Spinler <spinler@us.ibm.com> Thu Dec 06 13:53:53 2018 -0600
committer Ed Tanous <ed.tanous@intel.com> Thu Dec 13 21:55:40 2018 +0000
tree 66e2f9cb12acc71b188d50f9038f6f7a0a39a44d
parent 2ae600964780d469058a336eb38e9cfa30d41351

REST: For GET, return errors in JSON

For the failure cases, return the error messages
in JSON, the same as the python REST server does.

Change-Id: I150fec3ade738d1bd5425a3ea7cceb6c5539f9f6
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

include/openbmc_dbus_rest.hpp

diff --git a/include/openbmc_dbus_rest.hpp b/include/openbmc_dbus_rest.hpp
index 735db07..0ab3908 100644
--- a/include/openbmc_dbus_rest.hpp
+++ b/include/openbmc_dbus_rest.hpp
@@ -37,6 +37,7 @@
 const std::string notFoundMsg = "404 Not Found";
 const std::string notFoundDesc =
     "org.freedesktop.DBus.Error.FileNotFound: path or object not found";
+const std::string propNotFoundDesc = "The specified property cannot be found";
 
 void setErrorResponse(crow::Response &res, boost::beast::http::status result,
                       const std::string &desc, const std::string &msg)
@@ -999,7 +1000,8 @@
                                    const GetObjectType &object_names) {
             if (ec || object_names.size() <= 0)
             {
-                res.result(boost::beast::http::status::not_found);
+                setErrorResponse(res, boost::beast::http::status::not_found,
+                                 notFoundDesc, notFoundMsg);
                 res.end();
                 return;
             }
@@ -1015,7 +1017,8 @@
 
                 if (interfaceNames.size() <= 0)
                 {
-                    res.result(boost::beast::http::status::not_found);
+                    setErrorResponse(res, boost::beast::http::status::not_found,
+                                     notFoundDesc, notFoundMsg);
                     res.end();
                     return;
                 }
@@ -1064,10 +1067,19 @@
                             }
                             if (response.use_count() == 1)
                             {
-                                res.jsonValue = {{"status", "ok"},
-                                                 {"message", "200 OK"},
-                                                 {"data", *response}};
-
+                                if (!propertyName->empty() && response->empty())
+                                {
+                                    setErrorResponse(
+                                        res,
+                                        boost::beast::http::status::not_found,
+                                        propNotFoundDesc, notFoundMsg);
+                                }
+                                else
+                                {
+                                    res.jsonValue = {{"status", "ok"},
+                                                     {"message", "200 OK"},
+                                                     {"data", *response}};
+                                }
                                 res.end();
                             }
                         },