commit dd72e87b0588dcc2e2732cd47e5c9468a6386200
author Claire Weinan <cweinan@google.com> Mon Aug 15 14:20:06 2022 -0700
committer Ed Tanous <ed@tanous.net> Mon Aug 22 16:38:49 2022 +0000
tree a609037062260176baf678acb3d84ad26d3ba2c1
parent b4d7181a3956cab5a9136e2ffb338e8be2ccd06a

Fix function name handleLogServicesCollectionGet

Renamed handleLogServicesCollectionGet() to
handleBMCLogServicesCollectionGet() (added "BMC").

handleLogServicesCollectionGet() was a function first introduced in
https://gerrit.openbmc.org/c/openbmc/bmcweb/+/53175 but the function
name was accidentally made to be too broad. The function only handles
outputting the collection of LogServices specifically under
/redfish/v1/Managers/bmc/LogServices.

No expected client impact.

Tested:

Redfish Service Validator succeeded on the following URI:
/redfish/v1/Managers/bmc/LogServices/

Signed-off-by: Claire Weinan <cweinan@google.com>
Change-Id: I4648db2eaa5417c2428b514fdda1dbf82af0b3f0

redfish-core/lib/log_services.hpp

diff --git a/redfish-core/lib/log_services.hpp b/redfish-core/lib/log_services.hpp
index ee3ccfc..c3b659e 100644
--- a/redfish-core/lib/log_services.hpp
+++ b/redfish-core/lib/log_services.hpp
@@ -2004,7 +2004,7 @@
 
 constexpr char const* dumpManagerIface =
     "xyz.openbmc_project.Collection.DeleteAll";
-inline void handleLogServicesCollectionGet(
+inline void handleBMCLogServicesCollectionGet(
     crow::App& app, const crow::Request& req,
     const std::shared_ptr<bmcweb::AsyncResp>& asyncResp)
 {
@@ -2039,7 +2039,7 @@
         if (ec)
         {
             BMCWEB_LOG_ERROR
-                << "handleLogServicesCollectionGet respHandler got error "
+                << "handleBMCLogServicesCollectionGet respHandler got error "
                 << ec;
             // Assume that getting an error simply means there are no dump
             // LogServices. Return without adding any error response.
@@ -2083,7 +2083,7 @@
     BMCWEB_ROUTE(app, "/redfish/v1/Managers/bmc/LogServices/")
         .privileges(redfish::privileges::getLogServiceCollection)
         .methods(boost::beast::http::verb::get)(
-            std::bind_front(handleLogServicesCollectionGet, std::ref(app)));
+            std::bind_front(handleBMCLogServicesCollectionGet, std::ref(app)));
 }
 
 inline void requestRoutesBMCJournalLogService(App& app)