Chassis: Update LocationIndicatorActive property
Modify get/set of LocationIndicatorActive property for Chassis to use
identifying association instead of hard-coding D-Bus path to led
group.[1]
History: Almost 5 years ago IBM added support for this property to the
Chassis.[2] That original implementation assumed 1 chassis and just
looked at the enclosure_identify_blink and enclosure_identify like the
existing IndicatorLED property did.
IBM renamed these functions getSystemLocationIndicatorActive and
setSystemLocationIndicatorActive.[3] These functions are also used by
the system resource.
The interest from other companies has mostly been around IndicatorLED
(old deprecated LED property).[4]
Today, LEDs have the association documented above and used elsewhere
like PowerSupplies, Fans, etc. Switching to this association: 1) follows
the design 2) allows multiple chassis support 3) doesn't assume your
system led is your chassis led.
In the future:
1) system should also move to this association design
2) IndicatorLED should be deprecated - it has been 5 years
This could be put behind a compile flag but this function is broken with
the assumption the system/chassis are the same led. Let's just move to
the new design. IBM drove all these changes in and although other
companies have shown interest around LEDs in Redfish, there hasn't been
much in OpenBMC, so let's just fix.
[1] https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/58299
[2] https://gerrit.openbmc.org/c/openbmc/bmcweb/+/36886
[3] https://gerrit.openbmc.org/c/openbmc/bmcweb/+/57765
[4] https://gerrit.openbmc.org/c/openbmc/bmcweb/+/40969
Tested:
- Redfish Service Validator passes
- Confirm able to set and get LED
1. Get for Chassis
```
curl -k -H "X-Auth-Token: $token" -X GET https://${bmc}/redfish/v1/Chassis/chassis
{
"@odata.id": "/redfish/v1/Chassis/chassis",
"@odata.type": "#Chassis.v1_22_0.Chassis",
...
"LocationIndicatorActive": false,
...
}
```
2. Set for Chassis
```
curl -k -H "X-Auth-Token: $token" H "Content-Type: application/json" -X PATCH -d '{"LocationIndicatorActive":true}' https://${bmc}/redfish/v1/Chassis/chassis
curl -k -H "X-Auth-Token: $token" -X GET https://${bmc}/redfish/v1/Chassis/chassis
{
"@odata.id": "/redfish/v1/Chassis/chassis",
"@odata.type": "#Chassis.v1_22_0.Chassis",
...
"LocationIndicatorActive": true,
...
}
```
Change-Id: I78d07f82a8bbf91adb84e53178d3344ba95c9a14
Signed-off-by: Janet Adkins <janeta@us.ibm.com>
diff --git a/redfish-core/lib/chassis.hpp b/redfish-core/lib/chassis.hpp
index 27a7dbc..aab95bd 100644
--- a/redfish-core/lib/chassis.hpp
+++ b/redfish-core/lib/chassis.hpp
@@ -672,7 +672,7 @@
if (std::ranges::find(interfaces2, interface) != interfaces2.end())
{
getIndicatorLedState(asyncResp);
- getSystemLocationIndicatorActive(asyncResp);
+ getLocationIndicatorActive(asyncResp, objPath);
break;
}
}
@@ -834,8 +834,8 @@
{
if (indicatorChassis)
{
- setSystemLocationIndicatorActive(
- asyncResp, *locationIndicatorActive);
+ setLocationIndicatorActive(asyncResp, path,
+ *locationIndicatorActive);
}
else
{