commit e05aec50f10116e6dda7e377bc61799aa5b7c166
author Ed Tanous <edtanous@google.com> Tue Jan 25 10:28:56 2022 -0800
committer Ed Tanous <ed@tanous.net> Fri Feb 11 20:30:05 2022 +0000
tree 964aedffefcc787029c571a83889247caa0d3968
parent 213ffc701d838bece5893cda23475e7518bd6955

Add readability-redundant-* checks

There's a number of redundancies in our code that clang can sanitize
out.  Fix the existing problems, and enable the checks.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Ie63d7b7f0777b702fbf1b23a24e1bed7b4f5183b

redfish-core/lib/roles.hpp

diff --git a/redfish-core/lib/roles.hpp b/redfish-core/lib/roles.hpp
index c18942f..6c67a33 100644
--- a/redfish-core/lib/roles.hpp
+++ b/redfish-core/lib/roles.hpp
@@ -81,7 +81,7 @@
                const std::shared_ptr<bmcweb::AsyncResp>& asyncResp,
                const std::string& roleId) {
                 nlohmann::json privArray = nlohmann::json::array();
-                if (false == getAssignedPrivFromRole(roleId, privArray))
+                if (!getAssignedPrivFromRole(roleId, privArray))
                 {
                     messages::resourceNotFound(asyncResp->res, "Role", roleId);