Add readability-redundant-* checks
There's a number of redundancies in our code that clang can sanitize
out. Fix the existing problems, and enable the checks.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Ie63d7b7f0777b702fbf1b23a24e1bed7b4f5183b
diff --git a/redfish-core/lib/update_service.hpp b/redfish-core/lib/update_service.hpp
index ba92748..4b18520 100644
--- a/redfish-core/lib/update_service.hpp
+++ b/redfish-core/lib/update_service.hpp
@@ -263,7 +263,7 @@
int timeoutTimeSeconds = 10)
{
// Only allow one FW update at a time
- if (fwUpdateInProgress != false)
+ if (fwUpdateInProgress)
{
if (asyncResp)
{
@@ -819,7 +819,7 @@
std::string, std::vector<std::string>>>>& obj :
subtree)
{
- if (boost::ends_with(obj.first, *swId) != true)
+ if (!boost::ends_with(obj.first, *swId))
{
continue;
}