Enable readability-implicit-bool-conversion checks
These checks ensure that we're not implicitly converting ints or
pointers into bools, which makes the code easier to read.
Tested:
Ran series through redfish service validator. No changes observed.
UUID failing in Qemu both before and after.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I1ca0be980d136bd4e5474341f4fd62f2f6bbdbae
diff --git a/redfish-core/lib/ethernet.hpp b/redfish-core/lib/ethernet.hpp
index 5283fff..9b1aa43 100644
--- a/redfish-core/lib/ethernet.hpp
+++ b/redfish-core/lib/ethernet.hpp
@@ -685,7 +685,7 @@
// Count bits
for (long bitIdx = 7; bitIdx >= 0; bitIdx--)
{
- if (value & (1L << bitIdx))
+ if ((value & (1L << bitIdx)) != 0)
{
if (firstZeroInByteHit)
{
@@ -2355,7 +2355,7 @@
return;
}
// Need both vlanId and vlanEnable to service this request
- if (!vlanId)
+ if (vlanId == 0u)
{
messages::propertyMissing(asyncResp->res, "VLANId");
}