commit e662eae819f545ef07193f216b42e161b7ff7a46
author Ed Tanous <edtanous@google.com> Tue Jan 25 10:39:19 2022 -0800
committer Ed Tanous <ed@tanous.net> Tue Feb 15 00:35:55 2022 +0000
tree 2b13d88ae009fa7af3396252c8787992ff2cc6c8
parent c5ba4c27ddb28c7844c0ea3078df4114f531dd25

Enable readability-implicit-bool-conversion checks

These checks ensure that we're not implicitly converting ints or
pointers into bools, which makes the code easier to read.

Tested:
Ran series through redfish service validator.  No changes observed.
UUID failing in Qemu both before and after.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I1ca0be980d136bd4e5474341f4fd62f2f6bbdbae

redfish-core/lib/telemetry_service.hpp

diff --git a/redfish-core/lib/telemetry_service.hpp b/redfish-core/lib/telemetry_service.hpp
index 5457530..421985a 100644
--- a/redfish-core/lib/telemetry_service.hpp
+++ b/redfish-core/lib/telemetry_service.hpp
@@ -58,7 +58,7 @@
                     minInterval = std::get_if<uint64_t>(&var);
                 }
             }
-            if (!maxReports || !minInterval)
+            if (maxReports == nullptr || minInterval == nullptr)
             {
                 BMCWEB_LOG_ERROR
                     << "Property type mismatch or property is missing";