Enable readability-implicit-bool-conversion checks
These checks ensure that we're not implicitly converting ints or
pointers into bools, which makes the code easier to read.
Tested:
Ran series through redfish service validator. No changes observed.
UUID failing in Qemu both before and after.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I1ca0be980d136bd4e5474341f4fd62f2f6bbdbae
diff --git a/redfish-core/lib/trigger.hpp b/redfish-core/lib/trigger.hpp
index bb0a0e2..cdd5781 100644
--- a/redfish-core/lib/trigger.hpp
+++ b/redfish-core/lib/trigger.hpp
@@ -80,7 +80,7 @@
const std::vector<DiscreteThresholdParams>* discreteParams =
std::get_if<std::vector<DiscreteThresholdParams>>(&thresholdParams);
- if (!discreteParams)
+ if (discreteParams == nullptr)
{
return std::nullopt;
}
@@ -113,7 +113,7 @@
const std::vector<NumericThresholdParams>* numericParams =
std::get_if<std::vector<NumericThresholdParams>>(&thresholdParams);
- if (!numericParams)
+ if (numericParams == nullptr)
{
return std::nullopt;
}
@@ -204,7 +204,8 @@
}
}
- if (!name || !discrete || !sensors || !reports || !actions || !thresholds)
+ if (name == nullptr || discrete == nullptr || sensors == nullptr ||
+ reports == nullptr || actions == nullptr || thresholds == nullptr)
{
BMCWEB_LOG_ERROR
<< "Property type mismatch or property is missing in Trigger: "