Enable readability-implicit-bool-conversion checks
These checks ensure that we're not implicitly converting ints or
pointers into bools, which makes the code easier to read.
Tested:
Ran series through redfish service validator. No changes observed.
UUID failing in Qemu both before and after.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I1ca0be980d136bd4e5474341f4fd62f2f6bbdbae
diff --git a/redfish-core/lib/virtual_media.hpp b/redfish-core/lib/virtual_media.hpp
index ab27fc7..9e44e80 100644
--- a/redfish-core/lib/virtual_media.hpp
+++ b/redfish-core/lib/virtual_media.hpp
@@ -111,7 +111,7 @@
if (property == "WriteProtected")
{
const bool* writeProtectedValue = std::get_if<bool>(&value);
- if (writeProtectedValue)
+ if (writeProtectedValue != nullptr)
{
aResp->res.jsonValue["WriteProtected"] =
*writeProtectedValue;
@@ -126,7 +126,7 @@
if (property == "Active")
{
const bool* activeValue = std::get_if<bool>(&value);
- if (!activeValue)
+ if (activeValue == nullptr)
{
BMCWEB_LOG_DEBUG << "Value Active not found";
return;
@@ -578,7 +578,7 @@
SecureBuffer pack(FormatterFunc formatter)
{
SecureBuffer packed{new Buffer{}};
- if (formatter)
+ if (formatter != nullptr)
{
formatter(credentials.user(), credentials.password(), *packed);
}