commit ef47bb1886e2557b89efc9b09360dd0f994922bc
author Santosh Puranik <santosh.puranik@in.ibm.com> Tue Apr 30 10:28:52 2019 +0530
committer Ed Tanous <ed.tanous@intel.com> Wed May 29 18:53:37 2019 +0000
tree e99f23b5913048791d2a50a1eda16466f42bc4e3
parent 22c33710fed78a5c47446ee91ececf8b8ab104db

Set GraphicalConsole to enabled

This commit sets GraphicalConsole's ServiceEnabled property to true.
The ConnectTypesSupported is set to KVMIP.

Tested:
-- Ran redfish service validator. No errors seen.

Manager.v1_0_0.Manager:GraphicalConsole
        value: OrderedDict([('ConnectTypesSupported', ['KVMIP']),
('ServiceEnabled', True)]) <class 'collections.OrderedDict'>
        has Type: Manager.v1_0_0.GraphicalConsole complex
        is Optional
        ***going into Complex
Manager.v1_0_0.GraphicalConsole:ConnectTypesSupported
        value: ['KVMIP'] <class 'list'>
        has Type: Collection(Manager.v1_0_0.GraphicalConnectTypesSupported)
        enum is Optional
        permission OData.Permission/Read
        is Collection
        Success

-- GET on the manager shows the newly added properties.

curl -k -H "X-Auth-Token: $bmc_token" -X GET
https://${bmc}:${port}/redfish/v1/Managers/bmc
{
  "@odata.context": "/redfish/v1/$metadata#Manager.Manager",
  "@odata.id": "/redfish/v1/Managers/bmc",
....
....
  "GraphicalConsole": {
    "ConnectTypesSupported": [
      "KVMIP"
    ],
    "ServiceEnabled": true
  }
....
....
Change-Id: I169b581b7dd6b2cef96a2a3eb5f2ce3b1089c8b4
Signed-off-by: Santosh Puranik <santosh.puranik@in.ibm.com>

redfish-core/lib/managers.hpp

diff --git a/redfish-core/lib/managers.hpp b/redfish-core/lib/managers.hpp
index 829ce00..176c67f 100644
--- a/redfish-core/lib/managers.hpp
+++ b/redfish-core/lib/managers.hpp
@@ -1510,10 +1510,10 @@
         res.jsonValue["SerialConsole"]["ServiceEnabled"] = true;
         res.jsonValue["SerialConsole"]["ConnectTypesSupported"] = {"IPMI",
                                                                    "SSH"};
-        // TODO (Santosh) : Uncomment when KVM support is in.
-        // res.jsonValue["GraphicalConsole"]["ServiceEnabled"] = true;
-        // res.jsonValue["GraphicalConsole"]["ConnectTypesSupported"] =
-        //    {"KVMIP"};
+#ifdef BMCWEB_ENABLE_KVM
+        res.jsonValue["GraphicalConsole"]["ServiceEnabled"] = true;
+        res.jsonValue["GraphicalConsole"]["ConnectTypesSupported"] = {"KVMIP"};
+#endif // BMCWEB_ENABLE_KVM
 
         res.jsonValue["Links"]["ManagerForServers@odata.count"] = 1;
         res.jsonValue["Links"]["ManagerForServers"] = {