tree 4d5bfa3170b96f337dff31731dc60b2c8ef7ca3d
parent a88942019fdd3d8fc366999f7c178f3e1c18b2fe
author Abhilash Raju <abhilash.kollam@gmail.com> 1701338051 -0600
committer Abhilash Raju <abhilash.kollam@gmail.com> 1704779463 +0000

http_client:  fix for broken connection

http_client is not handling connection termination by server due to
keep alive timeout. At present client is not aware of connection
termination from server. So whenever next redfish is event ready to be
sent, the client will try send/receives data over broken connection.
After failed operation the client will try to restart the connection
by closing the current connection.

Problems:
1) Restart is not attempted on all failure paths.
Eg: stream_truncated error was ignored, which usually happens when try
to read from broken connection, due to which retry is never performed.

2) Ssl shutdown over broken connection often fails to call the shutdown
callback

3) ssl session was reused for new connection attempt. Which is wrong

Solution:

This patch will try to reattempt the connection in all failure cases.

It uses new socket object and  new ssl session for the retries

Tested by:

Test normal event flow between redfish-event clients and the BMC
Test failure event flow between redfish-event clients and the BMC
Tested the bad path by keeping the setup idle for 3 hours on the above
two setups. Verified the events flow after this idle time

Change-Id: I3d725b9d77bea22e2e8860e01ee0dfc971789008
Signed-off-by: Abhilash Raju <abhilash.kollam@gmail.com>
Signed-off-by: Ed Tanous <ed@tanous.net>