Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / bmcweb / f4ef2acd1f59d318a3cf66e8de835ce574a1356e
commitf4ef2acd1f59d318a3cf66e8de835ce574a1356e[log] [tgz]
authorChanyoung Park <park910113@gmail.com>Wed May 06 19:24:34 2020 -0700
committerChanyoung Park <park910113@gmail.com>Wed May 13 01:55:19 2020 +0000
tree93fd6ec1b25f3c6606b9917e5d5f3555b110cc38
parente9a14131650d30389eaf9dc38a3c32f1cb552f52 [diff]
Fix incorrect decoding of query string

QueryString class decodes incorrectly when it encounters
percent-encoded query strings "%xy", and cause the http
request class to have wrong query parameters. Fixed a bug
in the process of converting 2-digit hexadecimal number
to a single byte.

Tested:
 - Generate requests contains percent-encoded query strings
 - Check the urlParams field in crow::Request class and it
   works as expected

Example:
 - Before:
   GET https://{bmc}/...?a=b%20c&d=e
   req->urlParams: [ a=b, d=e ]
 - After:
   GET https://{bmc}/...?a=b%20c&d=e
   req->urlParams: [ a=b c, d=e ]

Signed-off-by: Chanyoung Park <park910113@gmail.com>
Change-Id: Ic1bfc74bbf4882e55445dba246ca769699fab332
1 file changed
tree: 93fd6ec1b25f3c6606b9917e5d5f3555b110cc38
  1. cmake/
  2. http/
  3. include/
  4. redfish-core/
  5. scripts/
  6. src/
  7. static/
  8. .clang-format
  9. .gitignore
  10. bmcweb.service.in
  11. bmcweb.socket
  12. build_x86.sh
  13. cmake-format.json
  14. CMakeLists.txt
  15. CMakeLists.txt.in
  16. config.h.in
  17. DEVELOPING.md
  18. JenkinsFile
  19. LICENCE
  20. MAINTAINERS
  21. pam-webserver
  22. README.md
  23. Redfish.md
README.md

OpenBMC webserver

This component attempts to be a "do everything" embedded webserver for openbmc.

Capabilities

At this time, the webserver implements a few interfaces:

  • Authentication middleware that supports cookie and token based authentication, as well as CSRF prevention backed by linux PAM authentication credentials.
  • An (incomplete) attempt at replicating phosphor-dbus-rest interfaces in C++. Right now, a few of the endpoint definitions work as expected, but there is still a lot of work to be done. The portions of the interface that are functional are designed to work correctly for phosphor-webui, but may not yet be complete.
  • Replication of the rest-dbus backend interfaces to allow bmc debug to logged in users.
  • An initial attempt at a read-only redfish interface. Currently the redfish interface targets ServiceRoot, SessionService, AccountService, Roles, and ManagersService. Some functionality here has been shimmed to make development possible. For example, there exists only a single user role.
  • SSL key generation at runtime. See the configuration section for details.
  • Static file hosting. Currently, static files are hosted from the fixed location at /usr/share/www. This is intended to allow loose coupling with yocto projects, and allow overriding static files at build time.
  • Dbus-monitor over websocket. A generic endpoint that allows UIs to open a websocket and register for notification of events to avoid polling in single page applications. (this interface may be modified in the future due to security concerns.

Configuration

BMCWeb is configured by setting -D flags that correspond to options in bmcweb/CMakeLists.txt and then compiling. For example, cmake -DBMCWEB_ENABLE_KVM=NO ... followed by make. The option names become C++ preprocessor symbols that control which code is compiled into the program.

When BMCWeb starts running, it reads persistent configuration data (such as UUID and session data) from a local file. If this is not usable, it generates a new configuration.

When BMCWeb SSL support is enabled and a usable certificate is not found, it will generate a self-sign a certificate before launching the server. The keys are generated by the secp384r1 algorithm. The certificate

  • is issued by C=US, O=OpenBMC, CN=testhost,
  • is valid for 10 years,
  • has a random serial number, and
  • is signed using the SHA-256 algorithm.