commit f926b099b33f9b2ed379d53f85687b27c0f5fa79
author Sunitha Harish <sunithaharish04@gmail.com> Mon Apr 13 02:58:57 2020 -0500
committer Sunitha Harish <sunithaharish04@gmail.com> Wed Jun 24 03:44:41 2020 +0000
tree 215bf472505d183f41ea5a9cf0655709aff6146a
parent 99a467faa172022896f2b6432fbecab8cbca5498

Validation enhancement for Hypervisor EthernetInterface update.

This commit returns propertyNotWritable error for Hypervisor "IPv4Addresses"
parameter. Without this, if the PATCH operation includes this parameter; then
bmcweb returns the error as "PropertyUnknown" which is not meaningful.

Tested By:

PATCH -D patch.txt -d '{"IPv4Addresses": [null]}' https://${bmc}/redfish/v1/Systems/hypervisor/EthernetInterfaces/<intf>
{
  "IPv4Addresses@Message.ExtendedInfo": [
    {
      "@odata.type": "#Message.v1_0_0.Message",
      "Message": "The property IPv4Addresses is a read only property and cannot be assigned a value.",
      "MessageArgs": [
        "IPv4Addresses"
      ],
      "MessageId": "Base.1.4.0.PropertyNotWritable",
      "Resolution": "Remove the property from the request body and resubmit the request if the operation failed.",
      "Severity": "Warning"
    }
  ]
}

Signed-off-by: Sunitha Harish <sunithaharish04@gmail.com>
Change-Id: Ia3bf142068128ab742864030b867d12e5c2697e0

redfish-core/lib/hypervisor_ethernet.hpp

diff --git a/redfish-core/lib/hypervisor_ethernet.hpp b/redfish-core/lib/hypervisor_ethernet.hpp
index 38759a1..7eb2748 100644
--- a/redfish-core/lib/hypervisor_ethernet.hpp
+++ b/redfish-core/lib/hypervisor_ethernet.hpp
@@ -682,13 +682,20 @@
         const std::string& ifaceId = params[0];
         std::optional<std::string> hostName;
         std::optional<nlohmann::json> ipv4StaticAddresses;
+        std::optional<nlohmann::json> ipv4Addresses;
 
         if (!json_util::readJson(req, res, "HostName", hostName,
-                                 "IPv4StaticAddresses", ipv4StaticAddresses))
+                                 "IPv4StaticAddresses", ipv4StaticAddresses,
+                                 "IPv4Addresses", ipv4Addresses))
         {
             return;
         }
 
+        if (ipv4Addresses)
+        {
+            messages::propertyNotWritable(asyncResp->res, "IPv4Addresses");
+        }
+
         if (ipv4StaticAddresses)
         {
             nlohmann::json ipv4Static = std::move(*ipv4StaticAddresses);