commit f94c4ecf9cf61b91b552731e4e03cd84c1070972
author Ed Tanous <edtanous@google.com> Thu Jan 06 12:44:41 2022 -0800
committer Ed Tanous <ed@tanous.net> Wed Jan 12 18:32:14 2022 +0000
tree 445183e7954963ab13afc255845237d5567aab53
parent cd5e430908916fad4cb9dcabf577cace2dca1cc5

Enable clang-tidy forward reference checks

Clang-13 adds new checks we can turn on, which find quite a few errors.

Tested: Code compiles

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I74b780760014c898cc440b37aea640b33e91c439

include/async_resolve.hpp

diff --git a/include/async_resolve.hpp b/include/async_resolve.hpp
index 306a499..105616d 100644
--- a/include/async_resolve.hpp
+++ b/include/async_resolve.hpp
@@ -27,7 +27,7 @@
         BMCWEB_LOG_DEBUG << "Trying to resolve: " << host << ":" << port;
         uint64_t flag = 0;
         crow::connections::systemBus->async_method_call(
-            [host, port, handler{std::move(handler)}](
+            [host, port, handler{std::forward<ResolveHandler>(handler)}](
                 const boost::system::error_code ec,
                 const std::vector<
                     std::tuple<int32_t, int32_t, std::vector<uint8_t>>>& resp,

include/dbus_utility.hpp

diff --git a/include/dbus_utility.hpp b/include/dbus_utility.hpp
index 4853231..872ca61 100644
--- a/include/dbus_utility.hpp
+++ b/include/dbus_utility.hpp
@@ -111,8 +111,9 @@
         std::vector<std::pair<std::string, std::vector<std::string>>>;
 
     crow::connections::systemBus->async_method_call(
-        [callback{std::move(callback)}](const boost::system::error_code ec,
-                                        const GetObjectType& objectNames) {
+        [callback{std::forward<Callback>(callback)}](
+            const boost::system::error_code ec,
+            const GetObjectType& objectNames) {
             callback(!ec && objectNames.size() != 0);
         },
         "xyz.openbmc_project.ObjectMapper",