commit f9c794fbf2053c664902efa5d9ef638ef08acb38
author Ed Tanous <edtanous@google.com> Tue Jun 06 11:46:49 2023 -0700
committer Ed Tanous <ed@tanous.net> Thu Jun 08 16:39:49 2023 +0000
tree 989875f90035b2c7207017cf0471d05a5256970e
parent 9ba73934501fc4bfe8edf74b8a0211701b6d58ca

Remove unused const-cast

std::string::data now has a non-const variation in c++20.  This allows
us to remove a NOLINT and follow the standard.

Tested: Login succeeds.

Change-Id: Ie49932fae8efa90afe1a238f7059924747300521
Signed-off-by: Ed Tanous <edtanous@google.com>

include/pam_authenticate.hpp

diff --git a/include/pam_authenticate.hpp b/include/pam_authenticate.hpp
index 4759e02..c06b7e9 100644
--- a/include/pam_authenticate.hpp
+++ b/include/pam_authenticate.hpp
@@ -92,8 +92,7 @@
     std::string userStr(username);
     std::string passStr(password);
 
-    // NOLINTNEXTLINE(cppcoreguidelines-pro-type-const-cast)
-    char* passStrNoConst = const_cast<char*>(passStr.c_str());
+    char* passStrNoConst = passStr.data();
     const struct pam_conv localConversation = {pamFunctionConversation,
                                                passStrNoConst};
     pam_handle_t* localAuthHandle = nullptr; // this gets set by pam_start