| commit | fa800c8a141aa4b209269e0fb50cae34aa24f75d | [log] [tgz] |
|---|---|---|
| author | Gunnar Mills <gmills@us.ibm.com> | Wed Nov 13 09:28:19 2024 -0600 |
| committer | Gunnar Mills <gunnar@gmills.xyz> | Fri Nov 15 16:02:17 2024 +0000 |
| tree | 0294edfcda6f945a1d44059a5ac64fdf38ac437f | |
| parent | d27c31e9371385fb83e31cb1c6754b113d2bdf17 [diff] |
Manager: Remove SerialConsole and TODO In 2020, the OCP Profile moved to accept SerialConsole in either Manager or System.[1] That was the reason of still having this code. SerialConsole was deprecated in Manager v1_10_0. v1_19_2 is the latest Manager version[2]. SerialConsole was added to System in 2021[3]. In 2023, SerialConsole was enhanced to get the status not just hardcode to enabled. [1]: https://github.com/opencomputeproject/HWMgmt-OCP-Profiles/issues/23 [2]: https://redfish.dmtf.org/schemas/v1/Manager.v1_19_2.json [3]: https://github.com/openbmc/bmcweb/commit/0e8ac5e706c531d2a3e2fc8390d9a31b90a91eb1 [4]: https://github.com/openbmc/bmcweb/commit/5c3e927283e32e1633ccd409f34ee17fab626ca1 Tested: Covered by automated tests. Change-Id: I0a95e9215d4aa4626a3da75c989cb7d5eaf94be1 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
diff --git a/Redfish.md b/Redfish.md index bddf966..fce89c8 100644 --- a/Redfish.md +++ b/Redfish.md
@@ -550,7 +550,6 @@ - Oem - PartNumber - PowerState -- SerialConsole - SerialNumber - ServiceEntryPointUUID - SparePartNumber
diff --git a/redfish-core/lib/managers.hpp b/redfish-core/lib/managers.hpp index 226e33d..82ee25f 100644 --- a/redfish-core/lib/managers.hpp +++ b/redfish-core/lib/managers.hpp
@@ -2115,15 +2115,6 @@ asyncResp->res.jsonValue["DateTimeLocalOffset"] = redfishDateTimeOffset.second; - // TODO (Gunnar): Remove these one day since moved to ComputerSystem - // Still used by OCP profiles - // https://github.com/opencomputeproject/OCP-Profiles/issues/23 - // Fill in SerialConsole info - asyncResp->res.jsonValue["SerialConsole"]["ServiceEnabled"] = true; - asyncResp->res.jsonValue["SerialConsole"]["MaxConcurrentSessions"] = - 15; - asyncResp->res.jsonValue["SerialConsole"]["ConnectTypesSupported"] = - nlohmann::json::array_t({"IPMI", "SSH"}); if constexpr (BMCWEB_KVM) { // Fill in GraphicalConsole info