| commit | 0489ec2084e45eac51b3bfdd7316902692ffd009 | [log] [tgz] |
|---|---|---|
| author | Matt Spinler <spinler@us.ibm.com> | Mon Jun 05 15:08:59 2023 -0500 |
| committer | Matt Spinler <spinler@us.ibm.com> | Thu Jun 15 16:36:56 2023 -0500 |
| tree | f2a6717d3477d98525d4d1c9c27139dd1cec4ee3 | |
| parent | 28c56bf19cf0b83fde9b834d13e0832824feae30 [diff] |
hwmontemp: Fix object type being passed to ctors The Sensor base class is now tacking on the 'xyz.openbmc_project.Configuration' prefix to the objectType argument passed into its constructor. But in createSensors() the value passed into the constructor was already the full interface name taken from the buildSensorConfigMap() output, so the prefix ended up being in the objectType member variable twice. This was causing the InterfacesRemoved handler to not find an interface match when entity-manager removed interfaces, leaving sensors on D-Bus for hardware that was no longer in the system. Fix it by stripping off all but the last segment before passing it to the sensor object constructor. Tested: Sensors are now removed from D-Bus when the corresponding objects are removed from entity-manager. Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: I3312a6cddbe2b175b89f8566d5c9359b7c2df201
dbus-sensors is a collection of sensor applications that provide the xyz.openbmc_project.Sensor collection of interfaces. They read sensor values from hwmon, d-bus, or direct driver access to provide readings. Some advance non-sensor features such as fan presence, pwm control, and automatic cpu detection (x86) are also supported.
runtime re-configurable from d-bus (entity-manager or the like)
isolated: each sensor type is isolated into its own daemon, so a bug in one sensor is unlikely to affect another, and single sensor modifications are possible
async single-threaded: uses sdbusplus/asio bindings
multiple data inputs: hwmon, d-bus, direct driver access
A typical dbus-sensors object support the following dbus interfaces:
Path /xyz/openbmc_project/sensors/<type>/<sensor_name>
Interfaces xyz.openbmc_project.Sensor.Value
xyz.openbmc_project.Sensor.Threshold.Critical
xyz.openbmc_project.Sensor.Threshold.Warning
xyz.openbmc_project.State.Decorator.Availability
xyz.openbmc_project.State.Decorator.OperationalStatus
xyz.openbmc_project.Association.Definitions
Sensor interfaces collection are described here.
Consumer examples of these interfaces are Redfish, Phosphor-Pid-Control, IPMI SDR.
dbus-sensor daemons are reactors that dynamically create and update sensors configuration when system configuration gets updated.
Using asio timers and async calls, dbus-sensor daemons read sensor values and check thresholds periodically. PropertiesChanged signals will be broadcasted for other services to consume when value or threshold status change. OperationStatus is set to false if the sensor is determined to be faulty.
A simple sensor example can be found here.
Sensor devices are described using Exposes records in configuration file. Name and Type fields are required. Different sensor types have different fields. Refer to entity manager schema for complete list.