commit 0e68f19968f2501701cb53a9a66506c7bc497a05
author Paul Fertser <fercerpav@gmail.com> Thu Aug 05 20:36:03 2021 +0300
committer Ed Tanous <ed@tanous.net> Fri Dec 10 04:54:51 2021 +0000
tree faea3f186bcee11ceab16a6569ac848f86a4ca2f
parent 544e7dc58cecef898fe7d684c3ba0fbce178cf2d

Revert "Add beep support for PSU"

This reverts commit 3046a0242cfde0cbf871f632c2c143b48ac30c71.

Apparently nobody knows what this was meant for, and having useless code
around is confusing.

Citing Ed Tanous: "This is likely leftover cruft from pulling
dbus-sensors into mainline."
(https://lists.ozlabs.org/pipermail/openbmc/2021-August/027166.html)

Change-Id: I92256d594ce7ca37b957fe86a2d99d9cc9c315af
Signed-off-by: Paul Fertser <fercerpav@gmail.com>

include/PSUEvent.hpp

diff --git a/include/PSUEvent.hpp b/include/PSUEvent.hpp
index 0821d3f..3a39164 100644
--- a/include/PSUEvent.hpp
+++ b/include/PSUEvent.hpp
@@ -61,8 +61,6 @@
     void restartRead();
     void handleResponse(const boost::system::error_code& err);
     void updateValue(const int& newValue);
-    void beep(const uint8_t& beepPriority);
-    static constexpr uint8_t beepPSUFailure = 2;
     boost::asio::posix::stream_descriptor inputDev;
     std::string psuName;
     std::string groupEventName;

src/PSUEvent.cpp

diff --git a/src/PSUEvent.cpp b/src/PSUEvent.cpp
index b02816f..44275a3 100644
--- a/src/PSUEvent.cpp
+++ b/src/PSUEvent.cpp
@@ -348,15 +348,6 @@
             *assertState = true;
             if (!assertMessage.empty())
             {
-                // For failure and configure error, spec requires a beep
-                if ((assertMessage == "OpenBMC.0.1.PowerSupplyFailed") ||
-                    (assertMessage ==
-                     "OpenBMC.0.1.PowerSupplyConfigurationError"))
-                {
-                    std::cout << " beep for " << assertMessage << "\n";
-                    beep(beepPSUFailure);
-                }
-
                 // Fan Failed has two args
                 if (assertMessage == "OpenBMC.0.1.PowerSupplyFanFailed")
                 {
@@ -382,17 +373,3 @@
     }
     value = newValue;
 }
-
-void PSUSubEvent::beep(const uint8_t& beepPriority)
-{
-    systemBus->async_method_call(
-        [](boost::system::error_code ec) {
-            if (ec)
-            {
-                std::cerr << "beep error (ec = " << ec << ")\n";
-                return;
-            }
-        },
-        "xyz.openbmc_project.BeepCode", "/xyz/openbmc_project/BeepCode",
-        "xyz.openbmc_project.BeepCode", "Beep", uint8_t(beepPriority));
-}