Clang-tidy-14 fixes
Do as the robot commands. All changes made automatically by tidy.
Tested: (Thanks Zhikui)
Downloaded and run on system. Sensors scan normally.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I752f37c9e7a95aa3be8e6980ba6e4b2b48b3395a
diff --git a/include/IpmbSensor.hpp b/include/IpmbSensor.hpp
index b006652..93c06fb 100644
--- a/include/IpmbSensor.hpp
+++ b/include/IpmbSensor.hpp
@@ -59,7 +59,7 @@
}
// Per IPMI 'Get Sensor Reading' specification
- if (data[1] & (1 << readingUnavailableBit))
+ if ((data[1] & (1 << readingUnavailableBit)) != 0)
{
return false;
}
@@ -81,15 +81,15 @@
boost::asio::io_service& io, const std::string& name,
const std::string& sensorConfiguration,
sdbusplus::asio::object_server& objectServer,
- std::vector<thresholds::Threshold>&& thresholds,
- uint8_t deviceAddress, uint8_t hostSMbusIndex,
- const float pollRate, std::string& sensorTypeName);
+ std::vector<thresholds::Threshold>&& thresholdData,
+ uint8_t deviceAddress, uint8_t hostSMbusIndex, float pollRate,
+ std::string& sensorTypeName);
~IpmbSensor() override;
void checkThresholds(void) override;
void read(void);
void init(void);
- std::string getSubTypeUnits(void);
+ std::string getSubTypeUnits(void) const;
void loadDefaults(void);
void runInitCmd(void);
bool processReading(const std::vector<uint8_t>& data, double& resp);