Clang-tidy-14 fixes
Do as the robot commands. All changes made automatically by tidy.
Tested: (Thanks Zhikui)
Downloaded and run on system. Sensors scan normally.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I752f37c9e7a95aa3be8e6980ba6e4b2b48b3395a
diff --git a/include/Thresholds.hpp b/include/Thresholds.hpp
index 94480bb..ae1f528 100644
--- a/include/Thresholds.hpp
+++ b/include/Thresholds.hpp
@@ -67,7 +67,7 @@
struct ThresholdTimer
{
- ThresholdTimer(boost::asio::io_service& ioService) : io(ioService)
+ explicit ThresholdTimer(boost::asio::io_service& ioService) : io(ioService)
{}
bool hasActiveTimer(const Threshold& threshold, bool assert)
@@ -118,10 +118,10 @@
std::vector<thresholds::Threshold>& thresholdVector,
const std::string* matchLabel = nullptr, const int* sensorIndex = nullptr);
-bool parseThresholdsFromAttr(std::vector<thresholds::Threshold>& thresholds,
- const std::string& inputPath,
- const double& scaleFactor,
- const double& offset = 0);
+bool parseThresholdsFromAttr(
+ std::vector<thresholds::Threshold>& thresholdVector,
+ const std::string& inputPath, const double& scaleFactor,
+ const double& offset = 0);
struct ThresholdDefinition
{
@@ -137,9 +137,9 @@
{Level::SOFTSHUTDOWN, 3, "SoftShutdown"},
{Level::HARDSHUTDOWN, 4, "HardShutdown"}}};
-std::string getInterface(const Level level);
+std::string getInterface(Level level);
-void persistThreshold(const std::string& baseInterface, const std::string& path,
+void persistThreshold(const std::string& path, const std::string& baseInterface,
const thresholds::Threshold& threshold,
std::shared_ptr<sdbusplus::asio::connection>& conn,
size_t thresholdCount, const std::string& label);