commit 2456dde72421cd4086ac43e619fb0817a55bf0a7
author Zhikui Ren <zhikui.ren@intel.com> Fri Sep 11 10:33:30 2020 -0700
committer Zhikui Ren <zhikui.ren@intel.com> Fri Sep 11 10:34:38 2020 -0700
tree 53d17039a5dddfac2c677848bf8e6720ec64a794
parent d540741e1c3327a74b17559039f3cdbabe17eea5

Revert "log debug information for sensor threshold assert events"

This reverts commit 9bf6804c2d76b92005ad9851cb052d407ea3117f.
This causes ipmbsensor crash

Change-Id: I8517d801ea1598b190c140f317ef29d1bc172ee0
Signed-off-by: Zhikui Ren <zhikui.ren@intel.com>

src/ADCSensor.cpp

diff --git a/src/ADCSensor.cpp b/src/ADCSensor.cpp
index aa7b50e..c3980e0 100644
--- a/src/ADCSensor.cpp
+++ b/src/ADCSensor.cpp
@@ -79,7 +79,6 @@
     }
     association = objectServer.add_interface(
         "/xyz/openbmc_project/sensors/voltage/" + name, association::interface);
-
     setInitialProperties(conn);
 }
 
@@ -168,9 +167,11 @@
         // todo read scaling factors from configuration
         try
         {
-            rawValue = std::stod(response);
-            double nvalue = (rawValue / sensorScaleFactor) / scaleFactor;
+            double nvalue = std::stod(response);
+
+            nvalue = (nvalue / sensorScaleFactor) / scaleFactor;
             nvalue = std::round(nvalue * roundFactor) / roundFactor;
+
             updateValue(nvalue);
         }
         catch (std::invalid_argument&)
@@ -192,7 +193,6 @@
     int fd = open(path.c_str(), O_RDONLY);
     if (fd < 0)
     {
-        std::cerr << "adcsensor " << name << " failed to open " << path << "\n";
         return; // we're no longer valid
     }
     inputDev.assign(fd);
@@ -201,14 +201,6 @@
         std::shared_ptr<ADCSensor> self = weakRef.lock();
         if (ec == boost::asio::error::operation_aborted)
         {
-            if (self)
-            {
-                std::cerr << "adcsensor " << self->name << " read cancelled\n";
-            }
-            else
-            {
-                std::cerr << "adcsensor read cancelled no self\n";
-            }
             return; // we're being canceled
         }
 
@@ -216,10 +208,6 @@
         {
             self->setupRead();
         }
-        else
-        {
-            std::cerr << "adcsensor weakref no self\n";
-        }
     });
 }