| commit | 278e177f35c710349f4b9c8766aa95dc9f4189f9 | [log] [tgz] |
|---|---|---|
| author | Tom Tung <shes050117@gmail.com> | Tue Dec 12 09:20:40 2023 +0800 |
| committer | Andrew Jeffery <andrew@codeconstruct.com.au> | Wed Dec 13 21:54:50 2023 +0000 |
| tree | 6aa3ba8a05e0acd41c90d7253605d651c7b3df0a | |
| parent | 819eb3230820b0babf49b71586176f6cd414f8cf [diff] |
HwmonTempMain: revert the type of bus and address back to uint64_t In I546e967abae7c0fb9fca645867e3037046037647, the type of bus and address in HwmonTempMain were updated to size_t. However, in some systems using i3c, the device name is composed by bus number and the provisioned ID [1]. The provisioned ID is a 48-bit value (MIPI I3C Basic, v1.1.1, section 5.1.4.1.1), which is greater than the range of size_t on e.g. 32-bit ARM platforms. Thus, reverting the type back to uint64_t. [1] Linux in-turn uses this Provisioned ID to identify the device, and exposes the Provisioned ID in the device name: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/i3c/master.c?h=v6.6#n1521 Tested: - added unit test passed. - can read temperature of the i3c devices from our system. Change-Id: I6f0e73aaf5f8d28e4bdedbe85646373463f6707f Signed-off-by: Tom Tung <shes050117@gmail.com>
dbus-sensors is a collection of sensor applications that provide the xyz.openbmc_project.Sensor collection of interfaces. They read sensor values from hwmon, d-bus, or direct driver access to provide readings. Some advance non-sensor features such as fan presence, pwm control, and automatic cpu detection (x86) are also supported.
runtime re-configurable from d-bus (entity-manager or the like)
isolated: each sensor type is isolated into its own daemon, so a bug in one sensor is unlikely to affect another, and single sensor modifications are possible
async single-threaded: uses sdbusplus/asio bindings
multiple data inputs: hwmon, d-bus, direct driver access
A typical dbus-sensors object support the following dbus interfaces:
Path /xyz/openbmc_project/sensors/<type>/<sensor_name>
Interfaces xyz.openbmc_project.Sensor.Value
xyz.openbmc_project.Sensor.Threshold.Critical
xyz.openbmc_project.Sensor.Threshold.Warning
xyz.openbmc_project.State.Decorator.Availability
xyz.openbmc_project.State.Decorator.OperationalStatus
xyz.openbmc_project.Association.Definitions
Sensor interfaces collection are described here.
Consumer examples of these interfaces are Redfish, Phosphor-Pid-Control, IPMI SDR.
dbus-sensor daemons are reactors that dynamically create and update sensors configuration when system configuration gets updated.
Using asio timers and async calls, dbus-sensor daemons read sensor values and check thresholds periodically. PropertiesChanged signals will be broadcasted for other services to consume when value or threshold status change. OperationStatus is set to false if the sensor is determined to be faulty.
A simple sensor example can be found here.
Sensor devices are described using Exposes records in configuration file. Name and Type fields are required. Different sensor types have different fields. Refer to entity manager schema for complete list.